[Pkg-sysvinit-devel] Re: Fixing hwclock.sh

[Thomas Hood]

Miquel van Smoorenburg wrote:
> On Fri, 2006-01-06 at 15:39 +0100, Thomas Hood wrote:
>> If any script would have to create a subshell in order to protect the sourcer's
>> environment then it shouldn't be a .sh script.
> 
> Ehm, well:
> 
>         case "$i" in
>                 *.sh)
>                         # Source shell script for speed.
>                         (
>                                 trap - INT QUIT TSTP
>                                 set start
>                                 . $i
>                         )
>                         ;;
> 
> .. *.sh script are already sourced in a subshell.


OK, three things.  First, what I meant to say was: If a certain script S is given
a .sh name and yet creates subshells in order to protect its sourcer's environment
then it would be simpler if S were given a non-.sh name and S didn't create those
subshells.

Second, what you show above looks good.

But, third, where did you get that code?  That's not how /etc/init.d/rc looks now.
-- 
Thomas