[Pkg-sysvinit-devel] Bug#386699: initscripts: checkroot.sh broken by fix for #386347 (patch attached)

[Dmitry Borodaenko]

Package: initscripts
Version: 2.86.ds1-18
Severity: critical
Justification: makes system unbootable

This upgrade has cost me Friday evening and better part of Saturday,
and both were very dear to me. Please, pretty-pretty please: next time
you make changes like that to a package as important as sysvinit, make
absolutely sure it is tested. If you can't test it yourself, find
someone who can (e.g. get in touch with me if you want to try it on a
system that has root partition encrypted with cryptsetup), or at least
release it to experimental first.

And, as is quite obvious from the patch, the damage is caused by a
really stupid mistake that could have been caught by a casual code
review.

I apologize if the above sounds harsh, but believe me, now that I've
finally fixed my system, I calmed down a lot, it was an hour ago when
I was angry. You have to agree, to have single package make your
system unbootable twice in the space of two days is a bit too much.
Unstable is supposed to only hold packages intended for stable, last
two releases of sysvinit definitely belong to experimental.

-- 
Dmitry Borodaenko
-------------- next part --------------
--- checkroot.sh	2006-09-08 07:28:00.000000000 +0100
+++ /etc/init.d/checkroot.sh	2006-09-09 16:37:16.000000000 +0100
@@ -152,10 +152,10 @@
 				        domount tmpfs shmfs /tmp \
 					&& cd /tmp \
 					&& umount -l /tmp \
-					&& mknod -m 600 rootdev b ${rdev%:*} ${rdev#*:} \
-					&& [ -e rootdev ]
+					&& mknod -m 600 $rootdev b ${rdev%:*} ${rdev#*:} \
+					&& [ -e $rootdev ]
 				then
-					rootdev=rootdev
+					rootdev=$rootdev
 				else
 					rootfatal=yes
 				fi