Bug#387894: [Pkg-sysvinit-devel] Bug#387894: sysv-rc: progress bar

[Petter Reinholdtsen]

[Jean-Damien Durand]
> abour progress bar, here are few fixes and suggestions.
> 
> - in debug mode, probably the call to usplash_write should just be echoed

Sounds good.

> - the count of number of scripts executed is approximate v.s. what happens
>   in reality (check if file exist, check of previous runlevel, etc.)
> - the computation of what fraction of the bar to fill is not guaranteed to
>   reach 0 or 100, because of rouding issues (100/3, then multiplied again)

Right.  Sounds like a good idea too.

> Please find attached a patch for all these issues, where I
> factorized the call to kill and start script in order to avoid code
> duplication. I let you check and/or reject it, no pb!

The patch change a lot of indentation, making it hard to track what
are real changes and what are just tabs converted to spaces.  It would
be better with a patch without these irrelevant whitespace changes.

> Tested with splashutils, not tested with bootsplash.

Is it tested with usplash too?