[Pkg-sysvinit-devel] Bug#426224: hddown.c and libata manage_start_stop

[Kel Modderman]

Hi,

The patch from pkg-sysvinit libata-fixes branch (r1054) that does global 
inhibition of -h halt option when 
`ls -1 /sys/class/scsi_disk/*/manage_start_stop' was true seems like an easy 
way out, but not a foolproof solution. That may not be true in all cases: one 
disk may have libata management of write flush and spindown, while another 
disk in the same system could conceivably not have that support.

Tejun Heo hinted[0] that a suse developer, Werner Fink, was working[1] on a 
more substantial effort to update hddown.c logic, providing per disk device 
decision on whether or not to give standby signal and cause flush of 
write-cache or not based on sysfs detection of attached disk devices.

Attached is diff against the libata branch of pkg-sysvinit that adds Werner's 
last patch[2]. I thought it was at least worth a go on my own hardware, if 
only for my own curiosity's sake. Seems to do what it advertises too.

Thanks, Kel.

[0] 
http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/2007-June/001963.html
[1]
https://bugzilla.novell.com/show_bug.cgi?id=229210
[2]
https://bugzilla.novell.com/attachment.cgi?id=145904
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sysvinit-libata.patch
Type: text/x-diff
Size: 14846 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/attachments/20070628/139276b6/attachment.patch