[Pkg-sysvinit-devel] Bug#444261: update-rc.d has a misleading online help

[Eddy Petrișor]

Package: sysvinit
Version: 2.86.ds1-38.1
Severity: minor
Tags: patch
File: update-rc.d


update-rc.d's online help is misleading.

This fails:

ritter:/etc/init.d# update-rc.d bip-eddy defaults s99 k00
update-rc.d: error: codenumber must be a number between 0 and 99
usage: update-rc.d [-n] [-f] <basename> remove
       update-rc.d [-n] <basename> defaults [NN | sNN kNN]
       update-rc.d [-n] <basename> start|stop NN runlvl [runlvl] [...] .
                -n: not really
                -f: force


While this does not (notice the missing 's' and 'k' before the numbers):

ritter:/etc/init.d# update-rc.d bip-eddy defaults 99 00
 Adding system startup for /etc/init.d/bip-eddy ...
   /etc/rc0.d/K00bip-eddy -> ../init.d/bip-eddy
   /etc/rc1.d/K00bip-eddy -> ../init.d/bip-eddy
   /etc/rc6.d/K00bip-eddy -> ../init.d/bip-eddy
   /etc/rc2.d/S99bip-eddy -> ../init.d/bip-eddy
   /etc/rc3.d/S99bip-eddy -> ../init.d/bip-eddy
   /etc/rc4.d/S99bip-eddy -> ../init.d/bip-eddy
   /etc/rc5.d/S99bip-eddy -> ../init.d/bip-eddy



Attached is a small patch that fixes the issue. I know that not having it clear
from the start which number is for which operation, but is a lot better than
trying sNN kNN...

Also, I think that having [NN | NN NN] in the online help gives a hint about the
fact that the two forms mean two different things (from a user PoV).


--- System information. ---
Architecture: amd64
Kernel:       Linux 2.6.21-2-amd64

Debian Release: lenny/sid
  900 testing         www.emdebian.org
  900 testing         snapshot.debian.net
  900 testing         security.debian.org
  900 testing         ftp.ro.debian.org
  900 testing         eddyp.homelinux.net
   10 unstable        ftp.ro.debian.org
   10 unstable        eddyp.homelinux.net

--- Package information. ---
Depends           (Version) | Installed
===========================-+-============
libc6            (>= 2.6-1) | 2.6.1-1
libselinux1     (>= 2.0.15) | 2.0.15-2+b1
libsepol1        (>= 2.0.3) | 2.0.3-1+b1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-misleading-help.diff
Type: text/x-diff
Size: 513 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/attachments/20070927/d8410821/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/attachments/20070927/d8410821/attachment.pgp