[Pkg-sysvinit-devel] Bug#493505: mountnfs: -1 is not a valid return value (for LSB)

[martin f krafft]

reassign 493505 lsb-base
retitle 493505 log_warning_msg: -1 is not a valid return value
severity 493505 serious
thanks

also sprach martin f krafft <madduck at debian.org> [2008.08.02.1837 -0300]:
> + [ -z if-up.d/mountnfs[vde0]: ]
> + echo -n if-up.d/mountnfs[vde0]: waiting for interface cable before doing NFS mounts
> if-up.d/mountnfs[vde0]: waiting for interface cable before doing NFS mounts
> + log_end_msg -1
> + [ -z -1 ]
> + log_end_msg_pre -1
> + :
> + log_use_fancy_output
> + TPUT=/usr/bin/tput
> + EXPR=/usr/bin/expr
> + [ -t 1 ]
> + [ x !=  ]
> + [ x != xdumb ]
> + [ -x /usr/bin/tput ]
> + [ -x /usr/bin/expr ]
> + /usr/bin/tput hpa 60
> + FANCYTTY=0
> + false
> + [ -1 -eq 0 ]
> + [ -1 -eq -1 ]
> + echo -e  (warning).
> -e  (warning).
> + log_end_msg_post -1
> + :
> + return -1
> return: 1: Illegal number: -1

Yeah, so this is a bug in lsb-base, sorry for not checking.

log_warning_msg () {
    if [ -n "${1:-}" ]; then
        log_begin_msg $@
    fi
    log_end_msg -1
}

This causes log_end_msg to return -1, which at least /bin/dash can't
handle. Thus this is a dash transition bug and hence
release-critical.

-- 
 .''`.   martin f. krafft <madduck at debian.org>
: :'  :  proud Debian developer, author, administrator, and user
`. `'`   http://people.debian.org/~madduck - http://debiansystem.info
  `-  Debian - when you have better things to do than fixing systems
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
Url : http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/attachments/20080802/98f51558/attachment.pgp