[Pkg-sysvinit-devel] Bug#507868: Bug#507868: please handle VERBOSE via log_daemon_msg/log_end_msg
Guido Günther
agx at sigxcpu.org
Fri Dec 5 09:29:23 UTC 2008
On Fri, Dec 05, 2008 at 09:59:56AM +0100, Petter Reinholdtsen wrote:
> [Guido Günther]
> > This looks like overkill and just reduces the readability. Wouldn't
> > it be better if the the lsb log_* functions would look at an env var
> > (LSB_VERBOSE or similar)?
>
> I believe each script writer need to decide on a per message basis if
> the message should be visible when VERBOSE=no (or kernel option quiet)
> is used, and thus believe it is the wrong approach to move the test to
> the log_* functions. The skeleton example just happen to believe all
> its messages should be hidden in quiet mode.
But wouldn't it be better to make all the log_* functions look at
LSB_VERBOSE by default and have a special set of functions that ignores
$LSB_VERBOSE?
I agree that it should be left to the script maintainer to decide what
is important and what isn't but the way we do it looks a bit like
overkill.
-- Guido
More information about the Pkg-sysvinit-devel
mailing list