[Pkg-sysvinit-devel] Bug#494001: Bug#494001: Minimum kernel requirement for Squeeze

[Roger Leigh]

On Sat, May 30, 2009 at 10:38:39AM +1000, Kel Modderman wrote:
> On Saturday 30 May 2009 10:02:31 Roger Leigh wrote:
> > Has any further progress been made on this?  Are there any changes to the
> > patch you are waiting on me for?
> 
> I think I applied the patch already to sysvinit package SVN [0]. Sorry have
> been a bit busy since then. We need to start talking about getting some
> new uploads happening, but there are quite a few changes I have made which
> need review but noone with much time to review 'em.
> 
> Can you have a good look at [0] for errors please?
> 
> [0] http://lists.alioth.debian.org/pipermail/pkg-sysvinit-commits/2009-May/001220.html

It looks fine.  The only slight oddity is the slight difference in logic
between checkroot.sh and postinst.  In particular, the need for

  touch /etc/mtab

in checkroot.sh

This uses:
        if [ Linux = "$KERNEL" ] && [ ! -L /etc/mtab ] && [ -f /proc/mounts ]
        then
                if touch /etc/mtab >/dev/null 2>&1
                then
                        rm -f /etc/mtab && ln -s /proc/mounts /etc/mtab
                else
                        log_warning_msg "cannot symlink /etc/mtab to /proc/mounts"
                fi
        fi

whereas the initscripts postinst uses:

if [ "$(uname -s)" = "Linux" ]
then
        if [ -f /etc/mtab ] && [ ! -L /etc/mtab ] && [ -f /proc/mounts ]
        then
                rm -f /etc/mtab && ln -s /proc/mounts /etc/mtab
        fi
fi

I'm guessing here it's to cope with a read-only root on startup that the
postinst doesn't need to care about.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/attachments/20090530/8afcaf75/attachment-0002.pgp>