[Pkg-sysvinit-devel] Bug#544565: Bug#544565: Wrong checks with CONCURRENCY=startpar or =shell

[Kel Modderman]

On Wednesday 02 September 2009 01:48:34 Cortese, Matteo wrote:
> Package: sysv-rc
> Version: 2.87dsf-2
> Tags: patch
> 
> See this snippet from /etc/init.d/rc:
> 
> # Check if we are able to use make like booting.  It require the
> # insserv package to be enabled.
> #
> if [ startpar = "$CONCURRENCY" ] || [ makefile = "$CONCURRENCY" ] ; then
>        test -s /etc/init.d/.depend.boot  || CONCURRENCY="none"
>        test -s /etc/init.d/.depend.start || CONCURRENCY="none"
>        test -s /etc/init.d/.depend.stop  || CONCURRENCY="none"
>        startpar -v      > /dev/null 2>&1 || CONCURRENCY="none"
> fi
> 
> As far as I understand, the .depend.* files are needed by startpar only
> when it is invoved with "-M". In other words, this check should be
> performed only when CONCURRENCY is set to "makefile", not when it is set
> to "startpar".

It also serves as a marker that insserv has been installed and reordered the
boot system. It should stay in my opnion.

> 
> Besides, the fourth test is for the presence of startpar itself. Note
> however that when CONCURRENCY is set to "shell" (which is deprecated,
> but still supported) this test is skipped, but the code that follows
> does indeed expect startpar to be present.

That is indeed an oversight.

Thanks, Kel.