[Pkg-sysvinit-devel] Bug#569032: Sends SIGUSR1 to init unconditionally, conflicts with upstart

Petter Reinholdtsen pere at hungry.com
Sat Mar 20 09:58:34 UTC 2010


[Michael Biebl]
> There was a bug in my previous patch (a missing '!'), noticed it
> after hitting the send button.
> 
> Please find attached an updated patch.

I see the point of only signaling init when the socket changed, but am
unsure if we want to look for upstart specific binaries in the generic
scripts.  Is there still a bug with upstart if this change is
implemented instead?

Index: debian/src/initscripts/etc/init.d/mountall.sh
===================================================================
--- debian/src/initscripts/etc/init.d/mountall.sh       (revision 1827)
+++ debian/src/initscripts/etc/init.d/mountall.sh       (working copy)
@@ -59,8 +59,8 @@
        then
                rm -f $INITCTL
                mknod -m 600 $INITCTL p
+               kill -USR1 1
        fi
-       kill -USR1 1

        #
        # Execute swapon command again, in case we want to swap to

I am not sure if this code is still needed, but believe we should keep
it until someone can verify that it is obsolete.

Happy hacking,
-- 
Petter Reinholdtsen





More information about the Pkg-sysvinit-devel mailing list