[Pkg-sysvinit-devel] Bug#583811: initscripts: cleanup + suggestions

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Sun May 30 20:21:32 UTC 2010

On Sun, 30 May 2010, Petter Reinholdtsen wrote:

> [Cristian Ionescu-Idbohrn]
> > Please have a look at the attached diff.
> Please provide a rationale for your proposed changes. :) Which
> problems are you trying to address, and why do you try to solve them
> like this?

The more important part is about not accounting for an empty list of pids
stored in variable OMITPIDS.

The other thing is about some inconsistancy in testing files with '-e' and
'-f', instead of, IMO, more correct '-r'.

One less important issue is about replacing a:

	for seq in 1 2 3 4 5 6 7 8 9 10; do

loop with a:

	while [ $seq -lt $max_seq ]; do

which is, IMO, a cleaner way to do the same.

Last, but not least, various cleanups:

* whitespace damage
* useless quotes
* repeated use of hardcoded path/name to one and the same app: initctl.



More information about the Pkg-sysvinit-devel mailing list