[Pkg-sysvinit-devel] Bug#545181: Review of committed patch for bug 545181; two minor issues

Josh Triplett josh at joshtriplett.org
Mon Dec 19 13:17:21 UTC 2011


On Mon, Dec 19, 2011 at 12:10:07PM +0000, Roger Leigh wrote:
> On Sat, Dec 17, 2011 at 04:15:03PM -0800, Josh Triplett wrote:
> > Hi,
> > 
> > Thanks for committing the patch for 545181.  I noticed three minor issues
> > in the committed version:
> > 
> > 1) The various references to 2.88dsf-14 need to say 2.88dsf-17, in
> > debian/control, debian/initscripts.preinst, and
> > debian/sysvinit-utils.NEWS.
> > 
> > 2) The date "Sun, 09 Oct 2011 01:50:15 -0700" in
> > debian/sysvinit-utils.NEWS needs updating to the current $(date -R).
> > 
> > 3) The stanza for the bootlogd changelog truncation in debian/rules
> > should appear in override_dh_installchangelogs-arch, not
> > override_dh_installchangelogs-indep, since bootlogd has "Architecture:
> > any".  It also needs a preceding "dh_installchangelogs -pbootlogd".
> 
> I've pushed these corrections to
>   git://anonscm.debian.org/collab-maint/sysvinit
> (branch bootlogd).  If you're happy with them, it can be merged onto
> master.

Looks good.  Please merge, and thanks!

- Josh Triplett





More information about the Pkg-sysvinit-devel mailing list