[Pkg-sysvinit-devel] Bug#653077: initscripts: cleanup patches for /etc/network/if-up.d/mountnfs

Petter Reinholdtsen pere at hungry.com
Sat Dec 24 12:49:28 UTC 2011


[Cristian Ionescu-Idbohrn]
> Please find attached a series of 21 patches, attempt to cleanup,
> robustify and improve performance and maintability of that script
> (triggerd by bug#625726.

I noticed you removed quite a lot of quotes around variables, which in
my view is to make the code less robust.  Why do you propose to remove
quotes around constructs like this:

> -		case "$FSTYPE" in
> +		case $FSTYPE in

I try to always put quotes around such variables as far of an effort to
do defensive programming, in case a space sneak into its value some time
in the future.
-- 
Happy hacking
Petter Reinholdtsen





More information about the Pkg-sysvinit-devel mailing list