[Pkg-sysvinit-devel] Bug#614895: Bug#614895: sysv-rc: Warning in update-rc.d swaps script and LSB Default values?

[Roger Leigh]

On Mon, Apr 09, 2012 at 06:08:27PM +1000, Kel Modderman wrote:
> Hi All,
> 
> > I think a better warning would be something like this:
> > update-rc.d: warning: default start runlevel arguments (2 3 4 5) do not match foobar Default-Start values (2 3 5)
> > update-rc.d: warning: default stop runlevel arguments (0 1 6) do not match foobar Default-Stop values (0 1)
> > 
> > 
> > A new patch would look something like:
> > 
> > --- update-rc.d	2011-02-23 18:40:15.000000000 -0800
> > +++ /usr/sbin/update-rc.d	2011-02-24 00:44:43.043783266 -0800
> > @@ -480,6 +480,7 @@
> >      my ($name, $act) = (shift, shift);
> >      my ($lsb_start_ref, $lsb_stop_ref, $arg_str, $lsb_str);
> >      my (@arg_start_lvls, @arg_stop_lvls, @lsb_start_lvls, @lsb_stop_lvls);
> > +    my $default_msg = ($act eq 'defaults') ? 'default' : '';
> >  
> >      ($lsb_start_ref, $lsb_stop_ref) = parse_def_start_stop("/etc/init.d/$name");
> >      @lsb_start_lvls = @$lsb_start_ref;
> > @@ -523,15 +524,15 @@
> >          join("\0", sort @arg_start_lvls) ne join("\0", sort @lsb_start_lvls)) {
> >          $arg_str = @arg_start_lvls ? "@arg_start_lvls" : "none";
> >          $lsb_str = @lsb_start_lvls ? "@lsb_start_lvls" : "none";
> > -        warning "$name start runlevel arguments ($arg_str) do not match",
> > -                "LSB Default-Start values ($lsb_str)";
> > +        warning "$default_msg start runlevel arguments ($arg_str) do not match",
> > +                "$name Default-Start values ($lsb_str)";
> >      }
> >      if ($#arg_stop_lvls != $#lsb_stop_lvls or
> >          join("\0", sort @arg_stop_lvls) ne join("\0", sort @lsb_stop_lvls)) {
> >          $arg_str = @arg_stop_lvls ? "@arg_stop_lvls" : "none";
> >          $lsb_str = @lsb_stop_lvls ? "@lsb_stop_lvls" : "none";
> > -        warning "$name stop runlevel arguments ($arg_str) do not match",
> > -                "LSB Default-Stop values ($lsb_str)";
> > +        warning "$default_msg stop runlevel arguments ($arg_str) do not match",
> > +                "$name Default-Stop values ($lsb_str)";
> >      }
> >  }
> > 
> > What do you think?
> 
> I agree with the patch, Roger would it possible to include this patch in
> sysvinit git please?

Sure.  Don't you have write access to it yourself?

(Hmm, I put it on collab-maint, but maybe that doesn't give the
pkg-sysvinit-devel group access unless you're in the Debian
group?  Maybe I should request a git repo specifically for the
group.)


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800