[Pkg-sysvinit-devel] Bug#738855: Bug#738855: initscripts: Skip killing root-owned process starting with @

[Petter Reinholdtsen]

Control: tags -1 -pending

I am still unsure about this approach, and have decided to revert the
change in git to have more time to consider it while still being able
to upload newer versions from git.  This was the change I removed:

--- a/debian/changelog
+++ b/debian/changelog
@@ -11,10 +11,6 @@ sysvinit (2.88dsf-52) UNRELEASED; urgency=low
     stopping using start-stop-daemon, and add $START_ARGS and $STOP_ARGS
     to allow init.d scripts to add arguments to the start-stop-daemon calls.
 
-  [ Dimitri John Ledkov ]
-  * In sendsigs, skip killing any root user process which name starts with
-    '@' character. (Closes: #738855)
-
  -- Petter Reinholdtsen <pere at debian.org>  Thu, 13 Feb 2014 13:23:35 +0100
 
 sysvinit (2.88dsf-51) unstable; urgency=low
diff --git a/debian/src/initscripts/etc/init.d/sendsigs b/debian/src/initscripts/etc/init.d/sendsigs
index cdf3384..04bd03c 100755
--- a/debian/src/initscripts/etc/init.d/sendsigs
+++ b/debian/src/initscripts/etc/init.d/sendsigs
@@ -58,20 +58,6 @@ do_stop () {
                done
        fi
 
-       # A convention introduced by systemd and documented in
-       # http://www.freedesktop.org/wiki/Software/systemd/RootStorageDaemons/
-       # is that process whos name starts with '@' shouldn't be killed during
-       # shutdown, as typically those processes are started to manage the
-       # filesystems.  Skip killing those as well before umounting file systems.
-       #
-       # TODO: don't use pgrep...
-       #
-       if [ -x /usr/bin/pgrep ]; then
-           for pid in $(pgrep -u root -f '^@'); do
-               OMITPIDS="${OMITPIDS:+$OMITPIDS }-o $pid"
-           done
-       fi
-
        # Flush the kernel I/O buffer before we start to kill
        # processes, to make sure the IO of already stopped services to
        # not slow down the remaining processes to a point where they

-- 
Happy hacking
Petter Reinholdtsen