[Pkg-sysvinit-devel] Bug#768138: uwsgi: Enhancement to uwsgi-emperor.init.d

[Jonas Smedegaard]

reassign 768138 sysvinit-utils
retitle 768138 sysvinit-utils: source default before checking daemon existence in init-d-script
thanks

Hi Tadej,

Quoting Tadej Janez (2014-11-05 11:21:17)
> I've overridden $DAEMON in my /etc/default/uwsgi-emperor file and 
> pointed it to "/usr/local/bin/uwsgi/", but then the init script failed 
> since it executes:
> # Exit if the package is not installed
> [ -x "$DAEMON" ] || exit 0
> 
> before loading the /etc/default/uwsgi-emperor file:
> # Read configuration variable file if it is present
> [ -r "/etc/default/uwsgi-emperor" ] && . "/etc/default/uwsgi-emperor"
[...]
> The solution is to put the two lines:
> # Exit if the package is not installed
> [ -x "$DAEMON" ] || exit 0
> 
> after:
> # Read configuration variable file if it is present
> [ -r "/etc/default/uwsgi-emperor" ] && . "/etc/default/uwsgi-emperor"
> 
> Please, consider this small init script change.

Thanks for your suggestion.  It does look like a harmless change, but I 
am not fully certain, and have also now switched to use the 
init-d-script handler from sysvinit-utils where it is no longer in my 
control to tune the code (and that's feature, not a bug).

It seems the init-d-script handler has same "wrong" order in its code as 
the uwsgi-emperor init script had until now, so I hereby reassign this 
bug to sysvinit-utils in the hope they agree it is harmless to flip the 
order of things.

Regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-sysvinit-devel/attachments/20141106/00150c52/attachment.sig>