[Pkg-sysvinit-devel] Bug#833687: Bug#833687: initscripts: Fix a few checkroot.sh warnings on GNU/kFreeBSD

[Jon Boden]

Hi Petter

On Mon, Aug 08, 2016 at 12:02:05AM +0200, Petter Reinholdtsen wrote:
> [Jon Boden]
> > This patch fixes a few warnings caused by checkroot.sh when running on
> > FreeBSD. The problem being that a few filesystems (tmpfs, linprocfs
> > and linsysfs) can't be remounted, so with attached patch remount is
> > avoided.
> 
> Thank you for the patch.  It make sense to me.  Is there a reason you
> went with a global $KERNEL in the shell library instead of using uname
> in the test like it is done in umountroot, umountnfs.sh and
> checkroot.sh?

It's a bit faster this way, as $KERNEL is only initialized once.

> Anyway, I find it better to set it when it is used, so I
> changed the code to set it in every function using the value.

As you like. I'm happy as long as it works :-)

> Please
> test the current git version and check if it work as you want it to on
> kFreeBSD.

Thanks! Will do.

> By the way, given the fact that the sysvinit package only is the default
> boot system on kFreeBSD and Hurd, and is without any active maintainers
> at the moment, would you as one of the people caring about kFreeBSD
> perhaps be interested in help taking care of the package in Debian?

I don't know about the future of sysvinit in Debian GNU/kFreeBSD, but in ubuntuBSD we're migrating to openrc as default option. That said we still rely on initscripts and support sysvinit for users who want it anyway. I'm fine with having git access in case we need to apply further fixes but other than that I wouldn't expect a lot of involvement on my part (sorry ;-)).

-- 
Jon Boden

ubuntuBSD -- The power of FreeBSD kernel with familiarity of Ubuntu OS!

http://www.ubuntubsd.org/ -- https://twitter.com/ubuntuBSD