[Pkg-tcltk-devel] Bug#467397: Bug#467397: tcl8.4: CFLAGS variable should be quoted on the commandline, not when set

[Steve Langasek]

On Mon, Feb 25, 2008 at 10:42:58AM +0300, Sergei Golovan wrote:

> On 2/25/08, Steve Langasek <vorlon at debian.org> wrote:

> >  The tcl8.4 debian/rules has an error in the handling of the CFLAGS variable:
> >  spaces should not be quoted in make variable assignments because the quotes
> >  become part of the variable content, but do need to be quoted when passing
> >  such variables to the shell via make rules.  The current debian/rules will
> >  cause build failures if CFLAGS is set in the environment, as a result of the
> >  quotes being handled wrong.

> >  Attached is a patch which corrects this issue.

> Thanks for the report and for the patch! The bug is fixed in SVN, but
> since it doesn't affect the package build in Debian I'll upload the
> fix later (on more urgent occasion).

Well, it affects any users trying to build the package in environment where
CFLAGS is set - but it doesn't affect the buildds, yes.

> BTW, all tcl8.? and tk8.? packages have this bug. And all of them have
> a fix applied in SVN (there's no need to report bugs against them).

Great, thanks - I was hoping those could all get fixed without a separate
bug for each :)

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org