[Pkg-tcltk-devel] tDOM review & sponsorship

[Sergei Golovan]

On 5/23/08, Stefan Sobernig <stefan.sobernig at wu-wien.ac.at> wrote:
>
>  Héctor and I have finished the adoption and pollishing of tDOM
>  0.8.3 (CVS HEAD)[*], including support for shared expat:
>

Is CVS HEAD so much better than released 0.8.2? And how can you be
sure that CVS HEAD which I'll use to build a tarball is the same as
yours?

>
> > As far as I understand, the current version uses internal expat. I
> > think it's unacceptable. We should use libexpat from Debian. An
> > example of patches which allow to use system-wide expat could be found
> > at svn://bamboo.nes.ru/debian/tcl/tdom/trunk
> >
>
>  See dpatch
> http://svn.debian.org/viewsvn/*checkout*/pkg-tcltk/tdom/trunk/debian/patches/shared-expat.dpatch?rev=615
> for details. The patch deviates a bit from the one in
> svn://bamboo.nes.ru/debian/tcl/tdom/trunk, namely it avoids
> the VPATH adjustment in Makefile.in (to allow builds with bundled expat,
> used as fallback strategy) and adds preprocessor conditionals for expat 1.95

A fallback strategy for which cases?

> vs. expat 2. This allows to support both building against expat 1.95 + 2 (as
> 2.0.1 is currently prepared for roll-out by the Debian XML/SGML group) as
> the package name/ SONAME etc. will not change according to the group (see
> email attached).
>
>  We also introduced a tdom-dev package. Based on Lintian 1.25.45, the
> packages are lintian clean.
>
>  We would kindly ask for your review and a sponsored upload.

For now:
0) Is 0.8.3 really necessary and why?
1) There's no way to get a correct original tarball. Prefereably it
should be made as get-orig-source target in debian/rules or precisely
described in debian/copyright.
2) Changelog mentiones 0.8.2-1 and 0.8.3-1. As they have never been
released, it may be better to merge them to a single entry.
3) 0.8.3 isn't a real version. It's a CVS snapshot. The version number
should reflect that. Usually an appended date is used for that (e.g.
0.8.3~20080525, ~ makes this version to be less than 0.8.3).

-- 
Sergei Golovan