[Pkg-tcltk-devel] Bug#896139: tcl-signal: please make the build reproducible

[Chris Lamb]

Source: tcl-signal
Version: 1.4.3-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that tcl-signal could not be built reproducibly.

This is because it uses the absolute build path in the configuration
file which naturally could never work on our users machines'

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/Reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/Reproducible-build.patch	2018-04-20 08:30:18.440349820 +0200
@@ -0,0 +1,21 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-04-20
+
+--- tcl-signal-1.4.3.orig/tclconfig/tcl.m4
++++ tcl-signal-1.4.3/tclconfig/tcl.m4
+@@ -4257,11 +4257,11 @@ AC_DEFUN([TEA_EXPORT_CONFIG], [
+ 	eval $1_LIB_FLAG="-l$1`echo ${PACKAGE_VERSION} | tr -d .`${DBGX}"
+ 	eval $1_STUB_LIB_FLAG="-l$1stub`echo ${PACKAGE_VERSION} | tr -d .`${DBGX}"
+     fi
+-    $1_BUILD_LIB_SPEC="-L`$CYGPATH $(pwd)` ${$1_LIB_FLAG}"
++    $1_BUILD_LIB_SPEC="-L`$CYGPATH ${pkglibdir}` ${$1_LIB_FLAG}"
+     $1_LIB_SPEC="-L`$CYGPATH ${pkglibdir}` ${$1_LIB_FLAG}"
+-    $1_BUILD_STUB_LIB_SPEC="-L`$CYGPATH $(pwd)` [$]{$1_STUB_LIB_FLAG}"
++    $1_BUILD_STUB_LIB_SPEC="-L`$CYGPATH ${pkglibdir}` [$]{$1_STUB_LIB_FLAG}"
+     $1_STUB_LIB_SPEC="-L`$CYGPATH ${pkglibdir}` [$]{$1_STUB_LIB_FLAG}"
+-    $1_BUILD_STUB_LIB_PATH="`$CYGPATH $(pwd)`/[$]{PKG_STUB_LIB_FILE}"
++    $1_BUILD_STUB_LIB_PATH="`$CYGPATH ${pkg_lib_dir}`/[$]{PKG_STUB_LIB_FILE}"
+     $1_STUB_LIB_PATH="`$CYGPATH ${pkglibdir}`/[$]{PKG_STUB_LIB_FILE}"
+ 
+     AC_SUBST($1_BUILD_LIB_SPEC)
--- a/debian/patches/series	2018-04-20 08:24:24.042537620 +0200
--- b/debian/patches/series	2018-04-20 08:30:38.960454643 +0200
@@ -1 +1,2 @@
 Replace-hardcoded-wish-call-in-test-script.patch
+Reproducible-build.patch