[Pkg-tcltk-devel] nsf / packaging 2.2.0 and bug 890052

[Sergei Golovan]

Hi Stefan,
On Wed, Nov 14, 2018 at 12:24 PM Stefan Sobernig
<stefan.sobernig at wu.ac.at> wrote:
>
> > However, I failed to spot the right place.
>
> Oh, it seems there is patching of tclConfig.sh.in in place:
>
> https://salsa.debian.org/tcltk-team/tcl8.6/blob/master/debian/patches/tclprivate.diff

This patch was not specifically made for build reproducibility, but
turned out to help with it as well.
Originally the idea was to allow some Tcl extensions, which require
private Tcl header to build,
to build using the tcl-dev and tk-dev packages. They originally used
private headers from the Tcl build
directory, but it's unavailable, so the headers are now copied to
/usr/include/tcl/tcl-private, and
the above patch replaces the original build directory by this system-wide one.

>
> I take this as the recommended practise.

I'd say that it's up to you to decide. But if there's software which
would benefit from nsf
private headers, then you can copy them to /usr/include and point
environment variables
in nsfConfig.sh to them. Anyway, leaving the original build paths in
nsfConfig.sh seems useless
to me. Also, the patch proposed in bug 890052 doesn't look fine to me.
It omits important
config script from the binary package.

Cheers!
-- 
Sergei Golovan