[Pkg-tcltk-devel] Bug#1048000: nsf: Fails to build source after successful build

[Lucas Nussbaum]

Source: nsf
Version: 2.3.0-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package nsf
> dpkg-buildpackage: info: source version 2.3.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Stefan Sobernig <stefan.sobernig at wu.ac.at>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean 
> dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
>    dh_auto_clean
> dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> 	make -j1 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf ./library/xotcl/doc/*-xotcl.html
> rm -rf libnsf2.3.0.so libnsfstub2.3.0.a *.a *.so *~ core gmon.out *.o pkgIndex.tcl generic/stub*/*.o ./receiver ./__test.log
> find . -type f -name \*~ -exec rm \{} \;
> rm -rf Makefile ./nsfConfig.sh ./library/xotcl/xotclsh ./library/xotcl/xowish ./unix/pkgIndex.unix nxsh nxwish ./doc/version.inc autom4te.cache/
> rm -f config.cache config.log config.status
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
> 	rm -f debian/debhelper-build-stamp
> 	rm -rf debian/.debhelper/
> dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> 	rm -f debian/nsf-dev.debhelper.log debian/nsf-shells.debhelper.log debian/nsf.debhelper.log
> 	rm -f -- debian/nsf.substvars debian/nsf-dev.substvars debian/nsf-shells.substvars debian/files
> 	rm -fr -- debian/nsf/ debian/tmp/ debian/nsf-dev/ debian/nsf-shells/
> 	find .  \( \( \
> 		\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
> 	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
> 		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
> 		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
> 		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
> 		\) -exec rm -f {} + \) -o \
> 		\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \)
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building nsf using existing ./nsf_2.3.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file nsf-2.3.0/doc/Class.3nx has no final newline (either original or modified version)
> dpkg-source: warning: file nsf-2.3.0/doc/Object.3nx has no final newline (either original or modified version)
> dpkg-source: warning: file nsf-2.3.0/doc/configure.3nx has no final newline (either original or modified version)
> dpkg-source: warning: file nsf-2.3.0/doc/current.3nx has no final newline (either original or modified version)
> dpkg-source: warning: file nsf-2.3.0/doc/next.3nx has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  nsf-2.3.0/doc/Class.3nx
>  nsf-2.3.0/doc/Object.3nx
>  nsf-2.3.0/doc/configure.3nx
>  nsf-2.3.0/doc/current.3nx
>  nsf-2.3.0/doc/next.3nx
>  nsf-2.3.0/library/mongodb/pkgIndex.tcl
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/nsf_2.3.0-1.diff.0eER0f
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/nsf_2.3.0-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.