[Pkg-tcltk-devel] Bug#1049044: xotcl: Fails to build source after successful build

[Lucas Nussbaum]

Source: xotcl
Version: 1.6.8-5
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package xotcl
> dpkg-buildpackage: info: source version 1.6.8-5
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Sergei Golovan <sgolovan at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh_testdir
> dh_testroot
> rm -f build-stamp 
> [ ! -f Makefile ] || /usr/bin/make distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf libxotcl1.6.8.so libxotclstub1.6.8.a *.o *.a *.so *~ core gmon.out xotclsh xowish pkgIndex.tcl ./receiver \
> 	./doc/*-xotcl.html
> find . -type f -name \*~ -exec rm \{} \;
> make[2]: Entering directory '/<<PKGBUILDDIR>>/library/store/XOTclSdbm'
> test -z "libxotclsdbm1.2.so" || rm -f libxotclsdbm1.2.so
> rm -f *.o core *.core
> test -z "pkgIndex.tcl" || rm -f pkgIndex.tcl
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/library/store/XOTclSdbm'
> make[2]: Entering directory '/<<PKGBUILDDIR>>/library/xml/TclExpat-1.1'
> test -z "libxotclexpat0.9.so" || rm -f libxotclexpat0.9.so
> rm -f *.o core *.core
> test -z "pkgIndex.tcl" || rm -f pkgIndex.tcl
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/library/xml/TclExpat-1.1'
> rm -rf Makefile Makefile xotclConfig.sh apps/utils/xotclsh apps/utils/xowish unix/xotcl.spec unix/pkgIndex.unix autom4te.cache/
> rm -f config.cache config.log config.status
> make[2]: Entering directory '/<<PKGBUILDDIR>>/library/store/XOTclSdbm'
> test -z "libxotclsdbm1.2.so" || rm -f libxotclsdbm1.2.so
> rm -f *.o core *.core
> test -z "pkgIndex.tcl" || rm -f pkgIndex.tcl
> rm -f *.tab.c
> rm -f Makefile
> rm -f config.cache config.log config.status
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/library/store/XOTclSdbm'
> make[2]: Entering directory '/<<PKGBUILDDIR>>/library/xml/TclExpat-1.1'
> test -z "libxotclexpat0.9.so" || rm -f libxotclexpat0.9.so
> rm -f *.o core *.core
> test -z "pkgIndex.tcl" || rm -f pkgIndex.tcl
> rm -f *.tab.c
> rm -f Makefile
> rm -f config.cache config.log config.status
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/library/xml/TclExpat-1.1'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> find . -name '*.o' -type f -delete
> find . -name '*.so' -type f -delete
> dh_clean config.log config.status config.cache config.guess
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building xotcl using existing ./xotcl_1.6.8.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  xotcl-1.6.8/doc/index.html
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/xotcl_1.6.8-5.diff.piFuOp
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/xotcl_1.6.8-5_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.