[Pkg-tcltk-devel] Bug#1075096: itk3: ftbfs with GCC-14

[Matthias Klose]

Package: src:itk3
Version: 3.4.2-3.1
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/itk3_3.4.2-3.1_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
checking for sin... no
checking for main in -lieee... no
checking for main in -linet... no
checking for net/errno.h... no
checking for connect... yes
checking for gethostbyname... yes
checking dirent.h... yes
checking for errno.h... yes
checking for float.h... yes
checking for values.h... yes
checking for limits.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for sys/wait.h... yes
checking for dlfcn.h... yes
checking for sys/param.h... yes
checking for Tcl public headers... /usr/include/tcl8.6
checking for Tcl private include files... Using srcdir found in tclConfig.sh: /usr/include/tcl8.6/tcl-private
checking for Tk public headers... /usr/include/tcl8.6
checking for Tk private include files... Using srcdir found in tkConfig.sh: /usr/include/tcl8.6/tk-private
checking for X... libraries , headers 
checking how to build libraries... shared
checking for ranlib... (cached) ranlib
checking if 64bit support is requested... no
checking if 64bit Sparc VIS support is requested... no
checking if compiler supports visibility "hidden"... yes
checking if rpath support is requested... yes
checking system version... Linux-6.1.0-21-cloud-amd64
checking for ar... ar
checking for cast to union support... yes
checking for required early compiler flags...  _LARGEFILE64_SOURCE
checking for 64-bit integer type... using long
checking for build with symbols... no
checking for tclsh... /usr/bin/tclsh8.6
checking for wish... /usr/bin/wish8.6
configure: creating ./config.status
config.status: creating Makefile
config.status: WARNING:  'Makefile.in' seems to ignore the --datarootdir setting
config.status: creating pkgIndex.tcl
config.status: creating itkConfig.sh
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make
make[2]: Entering directory '/<<PKGBUILDDIR>>'
gcc -DPACKAGE_NAME=\"itk\" -DPACKAGE_TARNAME=\"itk\" -DPACKAGE_VERSION=\"3.4\" -DPACKAGE_STRING=\"itk\ 3.4\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DBUILD_itk=/\*\*/ -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DTCL_THREADS=1 -DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -DHAVE_HIDDEN=1 -DHAVE_CAST_TO_UNION=1 -D_LARGEFILE64_SOURCE=1 -DTCL_WIDE_INT_IS_LONG=1 -DUSE_TCL_STUBS=1 -DUSE_TK_STUBS=1 -DUSE_ITCL_STUBS=1  -DITK_LIBRARY=\"/usr/lib/x86_64-linux-gnu/itk3.4\" -DUSE_NON_CONST -I"/usr/include/itcl3/itcl-private/generic" -I"./generic" -I"/usr/include/tcl8.6/tcl-private/generic" -I"/usr/include/tcl8.6/tcl-private/unix" -I"/usr/include/tcl8.6/tk-private/generic" -I"/usr/include/tcl8.6/tk-private/unix" -I"/usr/include/tcl8.6/tk-private/generic/ttk"     -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -pipe -O2 -fomit-frame-pointer -DNDEBUG -Wall -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -c `echo ./generic/itk_cmds.c` -o itk_cmds.o
In file included from /usr/include/itcl3/itcl-private/generic/itclInt.h:450,
                 from ./generic/itk.h:79,
                 from ./generic/itk_cmds.c:24:
./generic/itk_cmds.c: In function ‘Itk_ConfigBodyCmd’:
/usr/include/itcl3/itcl-private/generic/itclIntDecls.h:1160:25: error: passing argument 2 of ‘itclStubsPtr->itcl_EventuallyFree’ from incompatible pointer type [-Wincompatible-pointer-types]
 1160 |         (itclIntStubsPtr->itcl_DeleteMemberCode) /* 58 */
      |         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
      |                         |
      |                         void (*)(const char *)
./generic/itk_cmds.c:404:44: note: in expansion of macro ‘Itcl_DeleteMemberCode’
  404 |     Itcl_EventuallyFree((ClientData)mcode, Itcl_DeleteMemberCode);
      |                                            ^~~~~~~~~~~~~~~~~~~~~
/usr/include/itcl3/itcl-private/generic/itclIntDecls.h:1160:25: note: expected ‘void (*)(char *)’ but argument is of type ‘void (*)(const char *)’
 1160 |         (itclIntStubsPtr->itcl_DeleteMemberCode) /* 58 */
      |         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
./generic/itk_cmds.c:404:44: note: in expansion of macro ‘Itcl_DeleteMemberCode’
  404 |     Itcl_EventuallyFree((ClientData)mcode, Itcl_DeleteMemberCode);
      |                                            ^~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:278: itk_cmds.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:29: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:16: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2