[Pkg-tcltk-devel] Bug#1089451: tdom: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:53:48 +0100 Niels Thykier <niels at thykier.net> wrote:
> Source: tdom
> Version: 0.9.5-1
> Severity: important
> Tags: ftbfs
> Justification: FTBFS
> X-Debbugs-Cc: niels at thykier.net
> User: niels at thykier.net
> Usertags: rrr-no-as-default-issue
> 
> Dear maintainer,
> 
> During a test rebuild for building packages with
> `Rules-Requires-Root: no` as the default in `dpkg`,
> tdom failed to rebuild.
> 
> Log Summary:
> -------------------------------------------------------------------------------
> [...]
> 

Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on 
this. It would help me if you either uploaded this soon or approved the 
NMU (enabling me to skip the delay). Thanks in advance.

Best regards,
Niels
-------------- next part --------------
diff -Nru tdom-0.9.5/debian/changelog tdom-0.9.5/debian/changelog
--- tdom-0.9.5/debian/changelog	2024-10-17 21:02:11.000000000 +0200
+++ tdom-0.9.5/debian/changelog	2025-01-01 17:59:13.000000000 +0100
@@ -1,3 +1,11 @@
+tdom (0.9.5-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089451)
+
+ -- Niels Thykier <niels at thykier.net>  Wed, 01 Jan 2025 16:59:13 +0000
+
 tdom (0.9.5-1) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru tdom-0.9.5/debian/control tdom-0.9.5/debian/control
--- tdom-0.9.5/debian/control	2024-10-17 21:02:11.000000000 +0200
+++ tdom-0.9.5/debian/control	2025-01-01 17:58:52.000000000 +0100
@@ -4,6 +4,7 @@
 Maintainer: Tcl/Tk Debian Packagers <pkg-tcltk-devel at lists.alioth.debian.org>
 Uploaders: Hector Romojaro <hector.romojaro at gmail.com>, Stefan Sobernig <stefan.sobernig at wu-wien.ac.at>
 Build-Depends: debhelper (>= 13), tcl-dev, libexpat1-dev, libgumbo-dev, pkgconf, debhelper-compat (= 13)
+Rules-Requires-Root: no
 Standards-Version: 4.7.0
 Homepage: http://tdom.org/
 Vcs-Browser: https://salsa.debian.org/tcltk-team/tdom
diff -Nru tdom-0.9.5/debian/rules tdom-0.9.5/debian/rules
--- tdom-0.9.5/debian/rules	2024-10-17 21:02:11.000000000 +0200
+++ tdom-0.9.5/debian/rules	2025-01-01 17:58:41.000000000 +0100
@@ -100,7 +100,7 @@
 	# cp -R $(TARGET)/usr/include/tdom/* $(DEV)/usr/include/tdom
 
 	# move and fix tdomConfig.sh
-	install -d -m 755 -o root -g root $(DEV)/usr/lib/tcltk/$(DEB_HOST_MULTIARCH)/tdom$(VERSION)
+	install -d -m 755 $(DEV)/usr/lib/tcltk/$(DEB_HOST_MULTIARCH)/tdom$(VERSION)
 	mv $(ARCH_DEPENDENT)/tdomConfig.sh $(DEV)/usr/lib/tcltk/$(DEB_HOST_MULTIARCH)/tdom$(VERSION)/
 
 	perl -i -p \