[Pkg-tcltk-devel] Bug#1089353: itcl3: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:28:13 +0100 Niels Thykier <niels at thykier.net> wrote:
> Source: itcl3
> Version: 3.4.4-2
> Severity: important
> Tags: ftbfs
> Justification: FTBFS
> X-Debbugs-Cc: niels at thykier.net
> User: niels at thykier.net
> Usertags: rrr-no-as-default-issue
> 
> Dear maintainer,
> 
> During a test rebuild for building packages with
> `Rules-Requires-Root: no` as the default in `dpkg`,
> itcl3 failed to rebuild.
> 
> Log Summary:
> -------------------------------------------------------------------------------
> [...]
> 

Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on 
this. It would help me if you either uploaded this soon or approved the 
NMU (enabling me to skip the delay). Thanks in advance.

Best regards,
Niels

-------------- next part --------------
diff -Nru itcl3-3.4.4/debian/changelog itcl3-3.4.4/debian/changelog
--- itcl3-3.4.4/debian/changelog	2023-01-06 10:47:32.000000000 +0100
+++ itcl3-3.4.4/debian/changelog	2025-01-01 19:09:14.000000000 +0100
@@ -1,3 +1,11 @@
+itcl3 (3.4.4-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089353)
+
+ -- Niels Thykier <niels at thykier.net>  Wed, 01 Jan 2025 18:09:14 +0000
+
 itcl3 (3.4.4-2) unstable; urgency=medium
 
   * Revert the change which ports Itcl 3 to Tcl 8.7 because it breaks
diff -Nru itcl3-3.4.4/debian/control itcl3-3.4.4/debian/control
--- itcl3-3.4.4/debian/control	2023-01-06 10:47:32.000000000 +0100
+++ itcl3-3.4.4/debian/control	2025-01-01 19:04:56.000000000 +0100
@@ -4,6 +4,7 @@
 Maintainer: Debian Tcl/Tk Packagers <pkg-tcltk-devel at lists.alioth.debian.org>
 Uploaders: Sergei Golovan <sgolovan at debian.org>
 Build-Depends: debhelper-compat (= 13), tcl8.6-dev
+Rules-Requires-Root: no
 Standards-Version: 4.6.1
 Homepage: http://incrtcl.sourceforge.net/
 Vcs-Browser: https://salsa.debian.org/tcltk-team/itcl3
diff -Nru itcl3-3.4.4/debian/rules itcl3-3.4.4/debian/rules
--- itcl3-3.4.4/debian/rules	2023-01-06 10:47:32.000000000 +0100
+++ itcl3-3.4.4/debian/rules	2025-01-01 19:08:11.000000000 +0100
@@ -37,6 +37,8 @@
 		exec_prefix=$(dtmp)/usr \
 		includedir=$(dtmp)/usr/include/itcl$(vmajor) \
 		install
+	# Ensure sane basic permissions
+	chmod u+rwX -R $(dtmp)
 	#
 	# Fix up the itcl libraries.
 	mv $(dtmp)/usr/lib/$(DEB_HOST_MULTIARCH)/itcl*/libitcl$(v).so $(dtmp)/usr/lib/$(DEB_HOST_MULTIARCH)/libitcl$(v).so.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-tcltk-devel/attachments/20250101/297edfbb/attachment.sig>