[Pkg-tcltk-devel] Bug#1106836: unblock: tk9.0/9.0.1-3

[Sergei Golovan]

Package: release.debian.org
Severity: normal
X-Debbugs-Cc: tk9.0 at packages.debian.org
Control: affects -1 + src:tk9.0
User: release.debian.org at packages.debian.org
Usertags: unblock

Please unblock package tk9.0

[ Reason ]
The package fixes annoying bug with the size of fonts in
XFCE session on High DPI displays (see [1]). The displayed
text is twice as large as required by default.

[ Impact ]
The tk9.0 is not the default Tk versio, so the impact of this bug
will be fairly limited. But still it's nice to fix it.

[ Tests ]
There's no a special test for the difference, though they are
pretty trivial and the result can be seen by running a script like the
following:

label .l -text "Test Label"
pack .l

which shows huge text in XFCE session on a displya with DPI higher
than 160 (give or take).

[ Risks ]
The change is trivial, I dont expect any adverse effects for it.

[ Checklist ]
  [+] all changes are documented in the d/changelog
  [+] I reviewed all changes and I approve them
  [+] attach debdiff against the package in testing

[ Other info ]
(Anything else the release team should know.)

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1105050

unblock tk9.0/9.0.1-3
-------------- next part --------------
diff -Nru tk9.0-9.0.1/debian/changelog tk9.0-9.0.1/debian/changelog
--- tk9.0-9.0.1/debian/changelog	2025-03-25 12:38:40.000000000 +0300
+++ tk9.0-9.0.1/debian/changelog	2025-05-10 15:26:25.000000000 +0300
@@ -1,3 +1,11 @@
+tk9.0 (9.0.1-3) unstable; urgency=medium
+
+  * Never change ::tk::fontScalingFactor to a number different from 1 to
+    fix very large default fonts on high DPI displays in XFCE sessions
+    (closes: #1105050).
+
+ -- Sergei Golovan <sgolovan at debian.org>  Sat, 10 May 2025 15:26:25 +0300
+
 tk9.0 (9.0.1-2) unstable; urgency=medium
 
   * Move the Tcl part of the Tk library to /usr/lib from /usr/share/tcltk.
diff -Nru tk9.0-9.0.1/debian/patches/fontsizes.diff tk9.0-9.0.1/debian/patches/fontsizes.diff
--- tk9.0-9.0.1/debian/patches/fontsizes.diff	1970-01-01 03:00:00.000000000 +0300
+++ tk9.0-9.0.1/debian/patches/fontsizes.diff	2025-05-10 15:26:25.000000000 +0300
@@ -0,0 +1,24 @@
+From: Sergei Golovan
+Subject: Patch prevents Tk from setting font scaling factor to 2
+ in XFCE session when there is non-unity /Gdk/WindowScalingFactor
+ in effect. Tk font rendering does not depend on this scaling factor,
+ which means that if fontScalingFactor is set to 2 then the default
+ fonts appear twice as large as the correct ones.
+Date: Sat, 10 May 2025 15:17:03 +0300
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1105050
+
+--- a/library/scaling.tcl
++++ b/library/scaling.tcl
+@@ -58,9 +58,9 @@
+ 	    if {[catch {exec xfconf-query -c xsettings \
+ 		 -p /Gdk/WindowScalingFactor} result] == 0} {
+ 		set winScalingFactor $result
+-		if {$winScalingFactor >= 2} {
+-		    set fontScalingFactor 2
+-		}
++		#if {$winScalingFactor >= 2} {
++		#    set fontScalingFactor 2
++		#}
+ 	    }
+ 
+ 	    #
diff -Nru tk9.0-9.0.1/debian/patches/series tk9.0-9.0.1/debian/patches/series
--- tk9.0-9.0.1/debian/patches/series	2025-03-25 12:38:40.000000000 +0300
+++ tk9.0-9.0.1/debian/patches/series	2025-05-10 15:26:25.000000000 +0300
@@ -1,2 +1,3 @@
 tkprivate.diff
 versionedlibtkstub.diff
+fontsizes.diff