[Pkg-telepathy-maintainers] Bug#466817: FTBFS with GCC 4.3: ... defined but not used

[Moritz Muehlenhoff]

On Thu, Feb 21, 2008 at 09:29:14AM +0100, Martin Michlmayr wrote:
> Package: empathy
> Version: 0.21.90-2
> Severity: important
> Usertags: ftbfs-gcc-4.3
> 
> Your package fails to build with GCC 4.3.  Version 4.3 has not been
> released yet but I'm building with a snapshot in order to find errors
> and give people an advance warning.
> 
> You can reproduce this problem with gcc-4.3 from unstable.

This error is also reproducible with 0.22.0-1:

cc1: warnings being treated as errors
empathy-preferences.c:637: error: 'preferences_hookup_spin_button'
defined but not used
empathy-preferences.c:668: error: 'preferences_hookup_entry' defined
but not used
make[4]: *** [empathy-preferences.lo] Error 1
make[4]: Leaving directory
`/home/jmm/gcc/empathy-0.22.0/libempathy-gtk'
make[3]: *** [all] Error 2
make[3]: Leaving directory
`/home/jmm/gcc/empathy-0.22.0/libempathy-gtk'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/jmm/gcc/empathy-0.22.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/jmm/gcc/empathy-0.22.0'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status

There are dummy calls for both functions, which are now detected as
never being called by GCC 4.3:

        /* Silence warning. */
        if (0) {
                preferences_hookup_spin_button (preferences, key, widget);
        }

(..)

        if (0) {  /* Silent warning before we use this function. */
                preferences_hookup_entry (preferences, key, widget);
        }

Cheers,
        Moritz