[Pkg-telepathy-maintainers] Bug#550406: telepathy-glib: FTBFS on lenny

[Andres Salomon]

Package: telepathy-glib
Version: 0.9.0-1
Tags: patch

telepathy-glib fails to build on lenny with the following error:

make[4]: Entering directory `/yafono/telepathy-glib-0.9.0/examples/client'
\
#	source='inspect-channel.c' object='inspect-channel.o' libtool=no 
cc -std=gnu99 -DHAVE_CONFIG_H -I. -I../..    -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -Wnested-externs -Wpointer-arith -Wformat-security -Winit-self -Wno-missing-field-initializers -Wno-unused-parameter -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I../.. -I../.. -g -O2 -g -Wall -O2 -c inspect-channel.c
/bin/sh ../../libtool  --tag=CC   --mode=link cc -std=gnu99 -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -Wnested-externs -Wpointer-arith -Wformat-security -Winit-self -Wno-missing-field-initializers -Wno-unused-parameter -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I../.. -I../.. -g -O2 -g -Wall -O2  -Wl,-O1 -o telepathy-example-inspect-channel inspect-channel.o -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 ../../telepathy-glib/libtelepathy-glib.la 
libtool: link: cc -std=gnu99 -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -Wnested-externs -Wpointer-arith -Wformat-security -Winit-self -Wno-missing-field-initializers -Wno-unused-parameter -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I../.. -I../.. -g -O2 -g -Wall -O2 -Wl,-O1 -o .libs/telepathy-example-inspect-channel inspect-channel.o  -ldbus-glib-1 -ldbus-1 /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so -ldl /usr/lib/libglib-2.0.so ../../telepathy-glib/.libs/libtelepathy-glib.so
../../telepathy-glib/.libs/libtelepathy-glib.so: undefined reference to `g_simple_async_result_is_valid'
../../telepathy-glib/.libs/libtelepathy-glib.so: undefined reference to `g_set_error_literal'
collect2: ld returned 1 exit status
make[4]: *** [telepathy-example-inspect-channel] Error 1
make[4]: Leaving directory `/yafono/telepathy-glib-0.9.0/examples/client'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/yafono/telepathy-glib-0.9.0/examples'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/yafono/telepathy-glib-0.9.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/yafono/telepathy-glib-0.9.0'
make: *** [debian/stamp-makefile-build] Error 2


It would appear that the version of glib2.0 in lenny isn't new enough:

root at dev:/yafono/telepathy-glib-0.9.0# grep -r
g_simple_async_result_is_valid /usr/include/glib-2.0/
root at dev:/yafono/telepathy-glib-0.9.0# dpkg -l libglib2.0-dev
Desired=Unknown/Install/Remove/Purge/Hold |
Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err:
uppercase=bad) ||/ Name
Version                    Description
+++-==========================-==========================-====================================================================
ii  libglib2.0-dev             2.16.6-2                   Development
files for the GLib library root at dev:/yafono/telepathy-glib-0.9.0#

Upgrading to glib 2.22 fixes this:

root at dev:/yafono/telepathy-glib-0.9.0# dpkg -i ../libglib2.0-0_2.22.0-1~bpo50+1_i386.deb ../libglib2.0-dev_2.22.0-1~bpo50+1_i386.deb 
(Reading database ... 17922 files and directories currently installed.)
Preparing to replace libglib2.0-0 2.16.6-2 (using .../libglib2.0-0_2.22.0-1~bpo50+1_i386.deb) ...
Unpacking replacement libglib2.0-0 ...
Preparing to replace libglib2.0-dev 2.16.6-2 (using .../libglib2.0-dev_2.22.0-1~bpo50+1_i386.deb) ...
Unpacking replacement libglib2.0-dev ...
Setting up libglib2.0-0 (2.22.0-1~bpo50+1) ...
Setting up libglib2.0-dev (2.22.0-1~bpo50+1) ...
Processing triggers for man-db ...
root at dev:/yafono/telepathy-glib-0.9.0# grep -r g_simple_async_result_is_valid /usr/include/glib-2.0/
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:gboolean            g_simple_async_result_is_valid         (GAsyncResult            *result,
root at dev:/yafono/telepathy-glib-0.9.0# 


So, the package should have its versioned build-dep on glib bumped.  I
checked 2.18; it was missing the symbols.  2.20 introduced them.  The patch
below fixes this.






From 321a9c4551d09cb729e6a4641af3df07c35aaa7f Mon Sep 17 00:00:00 2001
From: Andres Salomon <dilinger at collabora.co.uk>
Date: Fri, 9 Oct 2009 16:32:45 -0400
Subject: [PATCH] Bump build-dep on glib2.0 to 2.20

Required for symbols like g_simple_async_result_is_valid.

Signed-off-by: Andres Salomon <dilinger at collabora.co.uk>
---
 debian/control |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/debian/control b/debian/control
index 7f7bb06..21493fa 100644
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@ Uploaders: Dafydd Harries <daf at debian.org>,
 Build-Depends: cdbs,
                dbus,
                debhelper (>= 5),
-               libglib2.0-dev (>= 2.16),
+               libglib2.0-dev (>= 2.20),
                libdbus-glib-1-dev (>= 0.73),
                libdbus-1-dev (>= 0.95),
                xsltproc,
-- 
1.6.4.3