[Pkg-tigervnc-devel] Bug#1004366: tigervnc-standalone-server: Use of uninitialized value in string eq at Config.pm line 401

[joachim.falk at gmx.de]

Package: tigervnc-standalone-server
Version: 1.11.0+dfsg-2
Severity: minor
Tags: patch
X-Debbugs-Cc: joachim.falk at gmx.de

Cosmetic error in case ~/.vnc/config contains at least one of

AlwaysShared = 0
NeverShared = 0

Then, tigervncserver commands will result in

Use of uninitialized value in string eq at /usr/share/perl5/TigerVNC/Config.pm line 414, <GEN0> line 4.
Use of uninitialized value in string eq at /usr/share/perl5/TigerVNC/Config.pm line 401, <GEN0> line 5.

-- System Information:
Debian Release: 11.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-11-amd64 (SMP w/16 CPU threads)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages tigervnc-standalone-server depends on:
ii  libaudit1                   1:3.0-2
ii  libbsd0                     0.11.3-1
ii  libc6                       2.31-13+deb11u2
ii  libfile-readbackwards-perl  1.05-2
ii  libgcrypt20                 1.8.7-6
ii  libgl1                      1.3.2-1
ii  libgnutls30                 3.7.1-5
ii  libjpeg62-turbo             1:2.0.6-4
ii  libpam0g                    1.4.0-9+deb11u1
ii  libpixman-1-0               0.40.0-1
ii  libselinux1                 3.1-3
ii  libstdc++6                  10.2.1-6
ii  libsystemd0                 247.3-6
ii  libunwind8                  1.3.2-2
ii  libxau6                     1:1.0.9-1
ii  libxdmcp6                   1:1.1.2-3
ii  libxfont2                   1:2.0.4-1
ii  perl                        5.32.1-4+deb11u2
hi  tigervnc-common             1.11.0+dfsg-2
ii  x11-xkb-utils               7.7+5
ii  xauth                       1:1.1-1
ii  xkb-data                    2.29-2
ii  zlib1g                      1:1.2.11.dfsg-2

Versions of packages tigervnc-standalone-server recommends:
ii  libgl1-mesa-dri    20.3.5-1
ii  x11-xserver-utils  7.7+8
ii  xfonts-base        1:1.0.5

Versions of packages tigervnc-standalone-server suggests:
ii  xfonts-100dpi    1:1.0.4+nmu1.1
ii  xfonts-75dpi     1:1.0.4+nmu1.1
ii  xfonts-scalable  1:1.0.3-1.2

-- Configuration Files:
/etc/tigervnc/vncserver.users changed [not included]

-- no debconf information
-------------- next part --------------
From 58104c25bf2c592609e6ba7ead84082261117e47 Mon Sep 17 00:00:00 2001
From: Joachim Falk <joachim.falk at gmx.de>
Date: Wed, 24 Mar 2021 22:03:19 +0100
Subject: [PATCH] Fixed warnings use of uninitialized value in string eq at
 /usr/share/perl5/TigerVNC/Config.pm line 401 or 414.

---
 debian/helpers/usr/share/perl5/TigerVNC/Config.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/debian/helpers/usr/share/perl5/TigerVNC/Config.pm b/debian/helpers/usr/share/perl5/TigerVNC/Config.pm
index 1644b3b..dfdb0d2 100644
--- a/debian/helpers/usr/share/perl5/TigerVNC/Config.pm
+++ b/debian/helpers/usr/share/perl5/TigerVNC/Config.pm
@@ -398,7 +398,8 @@ sub getOptionParseTable($$) {
           if (@_ == 2) {
             if ($_[1] eq '' || $_[1] eq '1') {
               &{$override}('shared', 'never');
-            } elsif ($options->{'shared'} eq 'never') {
+            } elsif (defined($options->{'shared'}) &&
+                     $options->{'shared'} eq 'never') {
               &{$override}('shared', undef);
             }
           } elsif (defined $options->{'shared'}) {
@@ -411,7 +412,8 @@ sub getOptionParseTable($$) {
           if (@_ == 2) {
             if ($_[1] eq '' || $_[1] eq '1') {
               &{$override}('shared', 'always');
-            } elsif ($options->{'shared'} eq 'always') {
+            } elsif (defined($options->{'shared'}) &&
+                     $options->{'shared'} eq 'always') {
               &{$override}('shared', undef);
             }
           } elsif (defined $options->{'shared'}) {
--
2.30.2