[Pkg-tigervnc-devel] Bug#1104740: -inetd-Option of Xnvc broken in version 1.15.0+dfsg-1

[Stephan Springl]

Package: tigervnc-standalone-server
Version: 1.15.0+dfsg-1
Severity: important
Tags: upstream patch
X-Debbugs-Cc: springl-rp at bfw-online.de

Hi,

upstream commit 5cd38b66896c00fd56e9c54eead430d02011c38f
"Print Xvnc banner before all the usage options" changes Xvnc to print
a banner even with -inetd option rendering it useless for inetd usage.
Xvnc will output to stdout

   Xvnc TigerVNC 1.15.0 - built 2025-04-18 09:01
   Copyright (C) 1999-2025 TigerVNC team and many others (see README.rst)
   See https://www.tigervnc.org for information on TigerVNC.
   Underlying X server release 12101016

   RFB 003.008

giving a protocol error for vnc clients.  Reverting the upstream commit
makes it usable again.  The following patch is not a complete revert,
but rather fewer changes than that:

diff --git a/unix/xserver/hw/vnc/xvnc.c b/unix/xserver/hw/vnc/xvnc.c
index 09d9732..ad442c6 100644
--- a/unix/xserver/hw/vnc/xvnc.c
+++ b/unix/xserver/hw/vnc/xvnc.c
@@ -214,6 +214,8 @@ ddxInputThreadInit(void)
 void
 ddxUseMsg(void)
 {
+    vncPrintBanner();
+
     ErrorF("-pixdepths list-of-int support given pixmap depths\n");
     ErrorF("+/-render             turn on/off RENDER extension support"
            "(default on)\n");
@@ -1259,7 +1261,5 @@ vncClientGone(int fd)
 int
 main(int argc, char *argv[], char *envp[])
 {
-    vncPrintBanner();
-
     return dix_main(argc, argv, envp);
 }

Regards,
Stephan Springl

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (550, 'testing'), (210, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 6.13.7-64+ (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=C, LC_CTYPE=de_DE (charmap=ISO-8859-1), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages tigervnc-standalone-server depends on:
ii  libaudit1                   1:4.0.2-2+b2
ii  libc6                       2.41-7bfw1
ii  libfile-readbackwards-perl  1.06-2
ii  libgbm1                     25.0.4-1
ii  libgcc-s1                   14.2.0-19bfw1
ii  libgl1                      1.7.0-1+b2
ii  libgmp10                    2:6.3.0+dfsg-3
ii  libgnutls30t64              3.8.9-2
ii  libhogweed6t64              3.10.1-1
ii  libjpeg62-turbo             1:2.1.5-3.1
ii  libnettle8t64               3.10.1-1
ii  libpam0g                    1.7.0-3
ii  libpixman-1-0               0.44.0-3
ii  libselinux1                 3.8.1-1
ii  libstdc++6                  14.2.0-19bfw1
ii  libsystemd0                 257.5-2
ii  libunwind8                  1.8.1-0.1
ii  libxau6                     1:1.0.11-1
ii  libxcvt0                    0.1.3-1
ii  libxdmcp6                   1:1.1.5-1
ii  libxfont2                   1:2.0.6-1+b3
ii  libxshmfence1               1.3.3-1
ii  perl                        5.40.1-2bfw1
ii  tigervnc-common             1.15.0+dfsg-1
ii  x11-xkb-utils               7.7+9
ii  xauth                       1:1.1.2-1.1
ii  xkb-data                    2.42-1bfw1
ii  zlib1g                      1:1.3.dfsg+really1.3.1-1+b1

Versions of packages tigervnc-standalone-server recommends:
ii  libgl1-mesa-dri    25.0.4-1
pn  tigervnc-tools     <none>
ii  x11-xserver-utils  7.7+11
ii  xfonts-base        1:1.0.5+nmu1

Versions of packages tigervnc-standalone-server suggests:
ii  openssl          3.5.0-1
ii  xfonts-100dpi    1:1.0.5
ii  xfonts-75dpi     1:1.0.5
pn  xfonts-scalable  <none>

-- Configuration Files:
/etc/X11/Xvnc-session changed [not included]
/etc/vnc.conf changed [not included]

-- no debconf information