[Pkg-tigervnc-devel] Bug#1146304: tigervnc: FTBFS with new libtool

[Vincent Lefevre]

Control: tags -1 patch

Since no-one has done anything yet and tigervnc got removed from
testing...

On 2026-08-31 09:19:05 +0000, Santiago Vila wrote:
> [...]
> test/Makefile.am:84: warning: source file 'xi2/xi2.c' is in a subdirectory,
> test/Makefile.am:84: but option 'subdir-objects' is disabled
> autoreconf: configure.ac: not running make: --make not given
> autoreconf: Leaving directory 'unix/xserver'
> cd /<<PKGBUILDDIR>>/unix/xserver && { \
>     patch --no-backup-if-mismatch -p1 < /<<PKGBUILDDIR>>/contrib/packages/deb/ubuntu-jammy/debian/xorg-source-patches/debian_libtool.patch; \
>   }
> patching file ltmain.sh
> Hunk #1 FAILED at 7890.
> 1 out of 1 hunk FAILED -- saving rejects to file ltmain.sh.rej

This is apparently due to first hunk of the following patch:

  contrib/packages/deb/ubuntu-jammy/debian/xorg-source-patches/debian_libtool.patch

Modifying debian/rules so that this patch is no longer applied (see
attached debian/rules) allows one to build tigervnc and run vncviewer.

I suppose that this patch was a workaround for a libtool bug, and this
is no longer needed with the new libtool.

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Pascaline project (LIP, ENS-Lyon)
-------------- next part --------------
--- debian/rules~	2025-04-24 20:48:11.000000000 +0200
+++ debian/rules	2026-10-02 15:55:59.432948366 +0200
@@ -20,8 +20,6 @@
 # debian specific copy instead.
 #VNC_PATCH = $(CURDIR)/debian/xserver121.patch
 
-VNC_LIBTOOL_PATCH = $(CURDIR)/contrib/packages/deb/ubuntu-jammy/debian/xorg-source-patches/debian_libtool.patch
-
 include /usr/share/dpkg/architecture.mk
 include /usr/share/dpkg/buildflags.mk
 
@@ -132,13 +130,6 @@
 	@echo '$$(DEB_CONFIGURE_EXTRA_FLAGS) $(DEB_CONFIGURE_EXTRA_FLAGS)'
 	@echo '$$(DEB_DESTDIR) $(DEB_DESTDIR)'
 
-.PHONY: override_dh_autoreconf
-override_dh_autoreconf:
-	dh_autoreconf
-	cd $(XTIGERVNC_SRCDIR) && { \
-	    patch --no-backup-if-mismatch -p1 < $(VNC_LIBTOOL_PATCH); \
-	  }
-
 .PHONY: override_dh_auto_configure
 override_dh_auto_configure:
 	dh_auto_configure -D$(TIGERVNC_SRCDIR) -B$(TIGERVNC_BUILDDIR) -- \