<div dir="ltr">Hi<div><br></div><div>I have started to review the control file. I have attached a change proposal based on my experience with vnc packaging from before.</div><div><br></div><div>I have also included the patch here with comments why I would like to do the changes. The comment is below the patch section.</div><div><br></div><div><br></div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">diff --git a/debian/control b/debian/control<br></font><font face="monospace, monospace">index d6abb8b..6b39817 100644<br></font><font face="monospace, monospace">--- a/debian/control<br></font><font face="monospace, monospace">+++ b/debian/control</font></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">@@ -5,7 +5,8 @@ Maintainer: TigerVNC Packaging Team <<a href="mailto:pkg-tigervnc-devel@lists.alioth.debian.org">pkg-tigervnc-devel@lists.alioth.debian.org</a>><br></font><font face="monospace, monospace"> Uploaders:<br></font><font face="monospace, monospace"> Joachim Falk <<a href="mailto:joachim.falk@gmx.de">joachim.falk@gmx.de</a>>,<br></font><font face="monospace, monospace"> Mike Gabriel <<a href="mailto:mike.gabriel@das-netzwerkteam.de">mike.gabriel@das-netzwerkteam.de</a>>,<br></font><font face="monospace, monospace">- Yaroslav Halchenko <<a href="mailto:debian@onerussian.com">debian@onerussian.com</a>><br></font><font face="monospace, monospace">+ Yaroslav Halchenko <<a href="mailto:debian@onerussian.com">debian@onerussian.com</a>>,<br></font><font face="monospace, monospace">+ Ola Lundqvist <<a href="mailto:opal@debian.org">opal@debian.org</a>><br></font><font face="monospace, monospace"> # all the Build-Depends up to x11proto-xf86-dri-dev are for the normal Xorg<br></font><font face="monospace, monospace"> # server, and common dependencies for the DIX.<br></font><font face="monospace, monospace"> # x11proto-xf86dri-dev and libdrm-dev are for DRI support for the Xorg server.</font></blockquote><div><br></div><div>Just adding myself.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">@@ -112,14 +113,14 @@ Depends:<br></font><font face="monospace, monospace"> Conflicts:<br></font><font face="monospace, monospace"> tigervnc-server (<< 1.1.90),<br></font><font face="monospace, monospace"> tigervnc-viewer (<< 1.1.90)<br></font><font face="monospace, monospace">-Description: Virtual network computing; Common software needed by clients and servers<br></font><font face="monospace, monospace">+Description: Virtual network computing; Common software needed by servers<br></font><font face="monospace, monospace"> VNC stands for Virtual Network Computing. It is, in essence, a remote<br></font><font face="monospace, monospace"> display system which allows you to view a computing `desktop' environment<br></font><font face="monospace, monospace"> not only on the machine where it is running, but from anywhere on the<br></font><font face="monospace, monospace"> Internet and from a wide variety of machine architectures.<br></font><font face="monospace, monospace"> .<br></font><font face="monospace, monospace"> It is implemented in a client/server model. This package provides the common<br></font><font face="monospace, monospace">- software for both client and server.<br></font><font face="monospace, monospace">+ software for servers.<br></font><font face="monospace, monospace"> <br></font><font face="monospace, monospace"> Package: tigervnc-scraping-server<br></font><font face="monospace, monospace"> Architecture: any</font></blockquote><div><br></div><div>The common tools are not needed by the viewer. The vncconfig tool is just to manage a Xvnc (or X with extension) server and the vncpasswd command is also just needed on the server side. Or am I missing something here?</div><div><br></div><div>I guess this packaging practice is a leftover from where tightvnc and vnc4 actually had a common package. Now the need arise again but just because we provide serveral server alternatives.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">@@ -131,7 +132,6 @@ Depends:<br></font><font face="monospace, monospace"> ${shlibs:Depends},<br></font><font face="monospace, monospace"> ${misc:Depends},<br></font><font face="monospace, monospace"> Recommends: libgl1-mesa-dri (>= 7.1~rc1)<br></font><font face="monospace, monospace">-Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable<br></font><font face="monospace, monospace"> Provides:<br></font><font face="monospace, monospace"> vnc-server,<br></font><font face="monospace, monospace"> ${videoabi},</font></blockquote><div><br></div><div>I do not think the scraping server need fonts on its own, or?</div><div><br></div><div>The below patch section is actually commented within the section itself as there are so many things that I propose.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">@@ -160,13 +160,15 @@ Depends:<br></font><font face="monospace, monospace"> keyboard-configuration [linux-any kfreebsd-any],<br></font><font face="monospace, monospace"> udev (>= 149) [linux-any],<br></font><font face="monospace, monospace"> tigervnc-common,<br></font><font face="monospace, monospace">+ xauth,<br></font><font face="monospace, monospace"> ${shlibs:Depends},<br></font><font face="monospace, monospace"> ${misc:Depends},<br></font><font face="monospace, monospace"> ${perl:Depends}</font></blockquote><div><br></div><div>The vncserver command actually depend on xauth so it should be here. I could accept a recommends as it is just the vncserver command that need it. The Xvnc command do not. However a dependency here is not really a problem as one would expect it to be there.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">-Recommends: libgl1-mesa-dri (>= 7.1~rc1)<br></font><font face="monospace, monospace">+Recommends: libgl1-mesa-dri (>= 7.1~rc1), xfonts-base, x11-xserver-utils<br></font><font face="monospace, monospace"> Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable</font></blockquote><div><br></div><div>xfonts-base is just to recommend a standard set of fonts. Previous vnc packages have had it but maybe it is not needed.</div><div><br></div><div>The recommendation on x11-server-utils is to get tools like xrandr, xauth and the like. They are quite useful... But maybe the contents have changed too many times since first added to the vnc suite.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace"> Provides:<br></font><font face="monospace, monospace"> vnc-server,<br></font><font face="monospace, monospace">+ xserver,<br></font><font face="monospace, monospace"> ${videoabi},<br></font><font face="monospace, monospace"> ${inputabi}<br></font><font face="monospace, monospace"> Replaces: tigervnc-server (<< 1.1.90)</font></blockquote><div><br></div><div>I think the vncserver package should declare that it is its own xserver. Not sure if this break some rule though. Tightvnc and vnc4 so so and I have not got any complaints about this.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">@@ -193,7 +195,7 @@ Depends:<br></font><font face="monospace, monospace"> tigervnc-common,<br></font><font face="monospace, monospace"> ${shlibs:Depends},<br></font><font face="monospace, monospace"> ${misc:Depends},<br></font><font face="monospace, monospace">-Recommends: libgl1-mesa-dri (>= 7.1~rc1)<br></font><font face="monospace, monospace">+Recommends: libgl1-mesa-dri (>= 7.1~rc1), xfonts-base, x11-xserver-utils<br></font><font face="monospace, monospace"> Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable<br></font><font face="monospace, monospace"> Provides:<br></font><font face="monospace, monospace"> vnc-server,</font></blockquote><div><br></div><div>Same comment as for the standalone server. Extension have same kind of need. However it is not its own xserver so it should not provide it.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace">@@ -215,11 +217,10 @@ Package: tigervnc-viewer<br> Architecture: any<br> Depends:<br> xserver-common (>= 2:1.7.7),<br>- tigervnc-common,<br> ${shlibs:Depends},<br> ${misc:Depends},</font></blockquote><div><br></div><div>The viewer do not need vncpasswd nor vncconfig. So I think we can remove it. If you know a use-case when it should be needed then please let me know.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><font face="monospace, monospace"> Provides:<br>- vnc-viewer<br>+ vncviewer, vnc-viewer<br> Description: Virtual network computing client software for X<br> VNC stands for Virtual Network Computing. It is, in essence, a remote<br> display system which allows you to view a computing `desktop' environment</font></blockquote></div><div><br></div><div>Historically the vnc4 and tightvnc packages have provided this vncviewer one too. However that is because we had a realvnc/vnc/vnc3 package many years ago that had this alias. Maybe we do not need to support transition cases that dates back 8 years or so... :-) I added it anyway.</div><div><br></div><div>What do you think?</div><div><br></div><div>// Ola</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 10:08 PM, Ola Lundqvist <span dir="ltr"><<a href="mailto:ola.lundqvist@gmail.com" target="_blank">ola.lundqvist@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Hi</p>
<p dir="ltr">Please upload anyway. I'll build on sid too but would like to do initial tests on stable.</p>
<p dir="ltr">/ Ola</p>
<p dir="ltr">Sent from a phone</p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">Den 25 jan 2016 21:56 skrev "Yaroslav Halchenko" <<a href="mailto:debian@onerussian.com" target="_blank">debian@onerussian.com</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On Mon, 25 Jan 2016, Ola Lundqvist wrote:<br>
<br>
> Thanks. I'll focus on the build and testing then. Do you happen to have a<br>
> backport of flvtk? I guess not but best to ask. :-)<br>
<br>
Well -- I do BUT non-official lazy backport and not sure if it wouldn't bring<br>
havoc to other tools. at least that prev version caused some FTBFS in stretch<br>
when last I have tried then (see below). but if you like I could upload it to<br>
e.g. -devel of the neurodebian repository. Although still -- better to<br>
build/make sure it works against sid at this point ;)<br>
<br>
% cat 1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch.summary<br>
<br>
Testing builds against fltk1.3_1.3.3-2.dsc<br>
ax25-tools_0.0.10-rc2+cvs20120204-4.dsc ok ok<br>
bist_0.5.2-1.dsc ok ok<br>
codfis_0.4.7-2.dsc ok ok<br>
csound_6.05~dfsg1-2.dsc ok ok<br>
dillo_3.0.5-1.dsc ok ok<br>
eureka_1.07-1.dsc ok ok<br>
fgrun_3.4.0.final-1.dsc ok FAILED /backup/neurodebian/deb/builds/fltk1.3/1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch/srcs/new/fgrun_3.4.0.final-1_amd64.build<br>
flamp_2.2.02-1.dsc ok ok<br>
fldigi_3.22.10-1.dsc ok ok<br>
flmsg_2.0.10-1.dsc ok ok<br>
flpsed_0.7.3-1.dsc ok ok<br>
flrig_1.3.22-1.dsc ok ok<br>
flwrap_1.3.4-2.1.dsc ok ok<br>
freecad_0.14.3702+dfsg-3.dsc ok ok<br>
freefem++_3.37.1-1.dsc ok ok<br>
giada_0.10.0~dfsg1-1.dsc ok ok<br>
gmsh_2.9.3+dfsg1-1.dsc ok ok<br>
goplay_0.9.dsc ok ok<br>
horgand_1.14-5.dsc ok ok<br>
imview_1.1.9c-12.dsc ok ok<br>
mathgl_2.2.2.1-3.dsc FAILED FAILED /backup/neurodebian/deb/builds/fltk1.3/1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch/srcs/new/mathgl_2.2.2.1-3_amd64.build<br>
obdgpslogger_0.16-1.2.dsc ok ok<br>
octave_3.8.2-4.1.dsc ok ok<br>
paulstretch_2.2-2-3.dsc ok ok<br>
relion_1.3+dfsg-2.dsc ok ok<br>
seaview_4.5.4.4-1.dsc ok ok<br>
trovacap_0.2.2-1.dsc ok ok<br>
tuxpaint-config_0.0.13-1.dsc ok ok<br>
xpp_1.5-cvs20081009-1.dsc ok ok<br>
yoshimi_1.3.5.1-2.dsc ok FAILED /backup/neurodebian/deb/builds/fltk1.3/1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch/srcs/new/yoshimi_1.3.5.1-2_amd64.build<br>
zynaddsubfx_2.4.3-6.dsc ok ok<br>
<br>
<br>
> I guessed that was the issue too. It did not work when I bumped back the<br>
> required number one number.<br>
> The problem is that if I'd like to test on stable if possible. But if that<br>
> do not really work, then I'll arrange some testing area.<br>
> // Ola<br>
> On Mon, Jan 25, 2016 at 9:42 PM, Yaroslav Halchenko <<a href="mailto:yoh@debian.org" target="_blank">yoh@debian.org</a>><br>
> wrote:<br>
<br>
> On Mon, 25 Jan 2016, Ola Lundqvist wrote:<br>
<br>
> >A A A primary problem was inclusion of xorg sources etc.AA Since<br>
> they we moved<br>
> >A A The interesting this is that vnc4 and tightvnc are still allowed<br>
> to be<br>
> >A A there. They have exactly the same problem... :-/<br>
<br>
> ;-)<br>
> >A A A away from that and there is now xorg-server-source so we<br>
> should all be<br>
> >A A A kosher and indeed aim to reupload.AA For that we need to<br>
> finish updating<br>
> >A A A it for 1.5.0 tigervnc or even jump over to recently released<br>
> >A A A 1.6.0; and then re-review all the copyright etc<br>
<br>
> >A A A But otherwise we indeed should be close to be ready ;)<br>
<br>
> >A A Great. What do you want me to focus on?<br>
> >A A - Review licenses?<br>
> >A A - Update to latest versions? (I still struggle to build the<br>
> current<br>
> >A A version as I'm still running stable I guess)<br>
> >A A - or something else?<br>
<br>
> building/testing latest version I guessA would be the most<br>
> valuable, especially with your expertise.<br>
<br>
> you would need stretch/sid due to necessity of fresh flvtk IIRC.<br>
> (s)chroot<br>
> might be sufficient ;)<br>
--<br>
Yaroslav O. Halchenko<br>
Center for Open Neuroscience <a href="http://centerforopenneuroscience.org" rel="noreferrer" target="_blank">http://centerforopenneuroscience.org</a><br>
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755<br>
Phone: <a href="tel:%2B1%20%28603%29%20646-9834" value="+16036469834" target="_blank">+1 (603) 646-9834</a> Fax: <a href="tel:%2B1%20%28603%29%20646-1419" value="+16036461419" target="_blank">+1 (603) 646-1419</a><br>
WWW: <a href="http://www.linkedin.com/in/yarik" rel="noreferrer" target="_blank">http://www.linkedin.com/in/yarik</a><br>
<br>
_______________________________________________<br>
Pkg-tigervnc-devel mailing list<br>
<a href="mailto:Pkg-tigervnc-devel@lists.alioth.debian.org" target="_blank">Pkg-tigervnc-devel@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tigervnc-devel" rel="noreferrer" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tigervnc-devel</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div>