[Pkg-utopia-maintainers] Bug#433638: Bug#433638: Bug#433638: preinst script should not use hardcode md5 for config files

[Sjoerd Simons]

On Wed, Jul 18, 2007 at 03:44:23PM +0200, Michael Biebl wrote:
> Sjoerd Simons wrote:
> > On Wed, Jul 18, 2007 at 01:54:03PM +0200, Laurent Bigonville wrote:
> >> Package: dbus
> >> Severity: normal
> >> Version: 1.1.1-3
> >>
> >> Hi,
> >>
> >> I don't think the preinst script should use hardcoded md5 for config
> >> files. There is an other method to check md5, please see:
> >> http://wiki.debian.org/DpkgConffileHandling
> > 
> > The md5sum was hardcoded for a reason :).. See:
> > 
> > r357 | sjoerd | 2005-11-10 08:49:15 +0000 (Thu, 10 Nov 2005) | 1 line
> > 
> > Pass the md5sum to rm_conffile, because dpkg looses track of it when
> > dbus-1-util is purged or upgraded
> > 
> > We could potentially remove this though. As the move was made before etch, so
> > we don't have to support it anymore strictly.. But i don't see any real reason
> > to remove it or to try to fix it while it's not broken :)
> 
> Oops, that means I was too hasty with my commit.
> Should I revert the change then? Do you see any problems?

Yes please revert it.

> About dpkg losing track of the md5sum:
> In case dbus-1-utils is purged, it shouldn't be an issue, as the
> conffile would be removed in this case anyway, right?

To be honest i don't remember the details anymore, it was almost two years ago
when i did this change :). There are some races though or maybe i just did
something silly...

> The only problem I can see is, that dbus Replaces dbus-1-utils. So the
> conffile can change ownership and move from the dbus-1-utils to the dbus
> package (in which case the PKGNAME would be wrong).
> This case can only happen though, when rm_conffile in dbus.preinst was
> added after the Replaces.

The problem i see is that your changing things that have been working fine for
almost two years for no real reason :)..

  Sjoerd
-- 
If A = B and B = C, then A = C, except where void or prohibited by law.
		-- Roy Santoro