[Pkg-utopia-maintainers] Bug#446963: Bug#446963: network-manager-gnome: Notification popups are more hindrance than help

[Tony Houghton]

On Wed, 14 Nov 2007 19:49:50 +0100
Michael Biebl <biebl at debian.org> wrote:

> Tony Houghton schrieb:
> > On Thu, 08 Nov 2007 21:46:17 +0100
> > Michael Biebl <biebl at debian.org> wrote:
> > 
> >> thanks for your suggestions. Instead of hiding the popups
> >> completely I'd prefer a similar mechanism like is used in
> >> gnome-power-manager. Show them by default, present a button in the
> >> tooltip saying "Don't show this ... anymore", which when pressed,
> >> set's the gconf key to false. Could you rework the patch to do
> >> that?
> > 
> > OK, I've managed to do that. I've added a menu entry as well as the
> > button in the popup so that it can easily be enabled again.
> > 
> > There are maybe a few things that could be cleaned up, but I'm
> > confident it works correctly. There are a few new strings that need
> > adding to the translations but that's beyond me.
> > 
> > I've split the patch up into two - the main changes I made and the
> > changes it causes to the files generated by autotools etc - to make
> > it easier to maintain.

I've left my earlier text in because I'm pretty sure I forgot to reply
to the bug address as well as you.

> There seems to be something broken with the patch.
> The schema file is installed into
> /@GCONF_SCHEMA_FILE_DIR@/...
> It seems, that gconf-2.m4 must somehow be included in aclocal.m4
> (either via acinclude.m4 or by intalling it into m4/ and setting
> AC_CONFIG_MACRO_DIR in configure.ac.
> I also assume that you have to call AM_GCONF_SOURCE_2 in configure.ac.

I forgot to add AM_GCONF_SOURCE_2 to configure.ac. Now it's there
aclocal automatically includes gconf-2.m4 in aclocal.m4 eg when called
by gnome-autogen.sh (which is what I used).

> Besides from that, the patch seems to work. The main concern now is
> the translations. I'm a bit reluctant to ship this patch with missing
> translations. If you can send me a fix for the issue above, I'll
> forward it to the upstream mailing list to see if upstream would be
> ok with it.

Good point about the translations. I hope they accept it. In case they
don't, I've realised that my original patch here was pointless because I
could have just used `./configure --without-notify'. I think that's what
Ubuntu have done in Gutsy. Would you consider that if this patch is
rejected?

-- 
TH * http://www.realh.co.uk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 40-disable_popups_option.patch
Type: text/x-patch
Size: 9146 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20071114/0c1d58a8/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 41-disable_popups_option_autogen.patch
Type: text/x-patch
Size: 218951 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20071114/0c1d58a8/attachment-0003.bin