[Pkg-utopia-maintainers] Bug#446963: network-manager-gnome: Notification popups are more hindrance than help

[Tony Houghton]

Package: network-manager-gnome
Version: 0.6.5-2
Severity: wishlist


I find the notification popups for non-critical events annoying. They
get in the way and mostly duplicate information already available by
looking at the tray icon. There's been no response to my bugrep upstream
<http://bugzilla.gnome.org/show_bug.cgi?id=455250> so please would you
accept this patch to disable non-critical popups. If you prefer I can
make the popups optional, using gconf.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.23.1 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages network-manager-gnome depends on:
ii  libc6                         2.6.1-5    GNU C Library: Shared libraries
ii  libdbus-1-3                   1.1.1-3    simple interprocess messaging syst
ii  libdbus-glib-1-2              0.74-1     simple interprocess messaging syst
ii  libgconf2-4                   2.20.0-1   GNOME configuration database syste
ii  libglade2-0                   1:2.6.2-1  library to load .glade files at ru
ii  libglib2.0-0                  2.14.1-5   The GLib library of C routines
ii  libgnome-keyring0             2.20.0-3   GNOME keyring services library
ii  libgnome2-0                   2.20.0-1   The GNOME 2 library - runtime file
ii  libgnomeui-0                  2.20.0-1   The GNOME 2 libraries (User Interf
ii  libgtk2.0-0                   2.12.0-2   The GTK+ graphical user interface 
ii  libnm-util0                   0.6.5-2    network management framework (shar
ii  libnotify1 [libnotify1-gtk2.1 0.4.4-3    sends desktop notifications to a n
ii  libpango1.0-0                 1.18.2-2   Layout and rendering of internatio
ii  libx11-6                      2:1.0.3-7  X11 client-side library
ii  network-manager               0.6.5-2    network management framework daemo

Versions of packages network-manager-gnome recommends:
ii  libpam-keyring                0.0.8-6+b1 PAM module that unlock gnome keyri
ii  notification-daemon           0.3.7-1+b1 a daemon that displays passive pop

-- no debconf information
-------------- next part --------------
--- network-manager-applet-0.6.5/src/applet-notifications.c	2007-10-16 01:27:15.000000000 +0100
+++ network-manager-applet-0.6.5.new/src/applet-notifications.c	2007-10-16 01:35:31.000000000 +0100
@@ -35,6 +35,12 @@
 	g_return_if_fail (applet != NULL);
 	g_return_if_fail (summary != NULL);
 	g_return_if_fail (message != NULL);
+	
+	if (urgency < NOTIFY_URGENCY_CRITICAL)
+	{
+		g_message("%s: %s", summary, message);
+		return;
+	}
 
 	if (!notify_is_initted ())
 		notify_init ("NetworkManager");