[Pkg-utopia-maintainers] Bug#474729: python-coherence: media_renderer.py doesn't import os.

[Franklin PIAT]

Package: python-coherence
Version: 0.5.2-1
Severity: important
Tags: patch


The file /usr/lib/python2.4/site-packages/coherence/upnp/devices/media_renderer.py uses os.path,
but doesn't import "os" beforehand.

A patch is attached ;)

Franklin


Enabling DNLA/UPnp in Rhythmbox typically produce the error message
(quoted mainly for googlers):
> WARN  coherence                   Apr 07 14:44:42  Coherence UPnP framework version 0.5.2 starting... (coherence/base.py:165)
> WARN  webserver                   Apr 07 14:44:42  WebServer on port 60182 ready (coherence/base.py:103)
> WARN  rb_media_renderer           Apr 07 14:44:42  __init__ RhythmboxPlayer {'shell': <rb.Shell object at 0x93ccdc4 (RBShell at 0x8194020)>, 'no_thread_needed': True, 'icon': {'url': 'file:///home/fpiat/.face', 'mimetype': 'image/png', 'depth': '24', 'height': '96', 'width': '96'}} (coherence/MediaPlayer.py:33)
> WARN  rb_media_renderer           Apr 07 14:44:42  get_volume 1.0 (coherence/MediaPlayer.py:357)
> Unhandled error in Deferred:
> Traceback (most recent call last):
>   File "/usr/lib/python2.4/site-packages/twisted/internet/gtk2reactor.py", line 216, in simulate
>     self.runUntilCurrent()
>   File "/usr/lib/python2.4/site-packages/twisted/internet/base.py", line 561, in runUntilCurrent
>     call.func(*call.args, **call.kw)
>   File "/usr/lib/python2.4/site-packages/twisted/internet/defer.py", line 239, in callback
>     self._startRunCallbacks(result)
>   File "/usr/lib/python2.4/site-packages/twisted/internet/defer.py", line 304, in _startRunCallbacks
>     self._runCallbacks()
> --- <exception caught here> ---
>   File "/usr/lib/python2.4/site-packages/twisted/internet/defer.py", line 317, in _runCallbacks
>     self.result = callback(self.result, *args, **kw)
>   File "/usr/lib/python2.4/site-packages/louie/plugin.py", line 103, in called
>     return receiver(*args, **kw)
>   File "/usr/lib/python2.4/site-packages/coherence/upnp/devices/media_renderer.py", line 233, in init_complete
>     icons=self.icons))
>   File "/usr/lib/python2.4/site-packages/coherence/upnp/devices/media_renderer.py", line 129, in __init__
>     ET.SubElement(i, k).text = '/'+uuid[5:]+'/'+os.path.basename(v)
> exceptions.NameError: global name 'os' is not defined
> WARN  rb_coherence_plugin         Apr 07 14:44:43  found upnp server Rhythmbox on 192.168.0.20 (uuid:e71991be-7a85-47a5-a5bf-d19d9335fce1::upnp:rootdevice) (coherence/__init__.py:144)
> WARN  coherence                   Apr 07 14:45:01  Coherence UPnP framework shutdown (coherence/base.py:322)

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (50, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages python-coherence depends on:
ii  python                        2.4.4-6    An interactive high-level object-o
ii  python-celementtree           1.0.5-9    Light-weight toolkit for XML proce
ii  python-central                0.6.1      register and build utility for Pyt
ii  python-configobj              4.4.0-2    a simple but powerful config file 
ii  python-ctypes                 1.0.2-2    Python package to create and manip
ii  python-elementtree            1.2.6-11   Light-weight toolkit for XML proce
ii  python-gst0.10                0.10.11-1  generic media-playing framework (P
ii  python-louie                  1.1-1      Python signal dispatching mechanis
ii  python-pkg-resources          0.6c8-2    Package Discovery and Resource Acc
ii  python-twisted-core           2.5.0-2    Event-based framework for internet
ii  python-twisted-web            0.7.0-1    An HTTP protocol implementation to
ii  python-zopeinterface          3.3.1-5    The implementation of interface de

python-coherence recommends no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: coherence_import_os.diff
Type: text/x-java
Size: 361 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20080407/720b2c32/attachment.java