[Pkg-utopia-maintainers] Bug#459480: network-manager: Problem with LSB header in init.d script

[Petter Reinholdtsen]

Package:  network-manager
Version:  0.6.4-8
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

When testing dependency based boot sequencing, I discovered what I
believe is a bug in the init.d/network-manager and
init.d/network-manager-dispatcher scripts.  Both need a mounted /usr/,
but do not depend on $remote_fs which is the dependency required for
scripts needing /usr/.  It only depend on $local_fs, which do not give
this guarantee.  Also, both list S as one of the stop runlevels, but
no script should ever stop in the boot "runlevel".

This patch should solve the issue.

diff -ur network-manager-0.6.5.orig/debian/network-manager.init network-manager-0.6.5/debian/network-manager.init
--- network-manager-0.6.5.orig/debian/network-manager.init      2008-01-06 20:48:31.000000000 +0100
+++ network-manager-0.6.5/debian/network-manager.init   2008-01-06 21:04:27.000000000 +0100
@@ -1,12 +1,12 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          NetworkManager
-# Required-Start:    $local_fs dbus dhcdbd hal
-# Required-Stop:     $local_fs dbus dhcdbd hal
+# Required-Start:    $remote_fs dbus dhcdbd hal
+# Required-Stop:     $remote_fs dbus dhcdbd hal
 # Should-Start:             $syslog
 # Should-Stop:       $syslog
 # Default-Start:     2 3 4 5
-# Default-Stop:      S 0 1 6
+# Default-Stop:      0 1 6
 # Short-Description: network connection manager
 # Description:       Daemon for automatically switching network
 #                   connections to the best available connection.
diff -ur network-manager-0.6.5.orig/debian/network-manager.network-manager-dispatcher.init network-manager-0.6.5/debian/network-manager.network-manager-dispatcher.init
--- network-manager-0.6.5.orig/debian/network-manager.network-manager-dispatcher.init   2008-01-06 20:48:31.000000000 +0100
+++ network-manager-0.6.5/debian/network-manager.network-manager-dispatcher.init        2008-01-06 21:03:59.000000000 +0100
@@ -1,12 +1,12 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          NetworkManagerDispatcher
-# Required-Start:    $local_fs
-# Required-Stop:     $local_fs
+# Required-Start:    $remote_fs
+# Required-Stop:     $remote_fs
 # Should-Start:             $syslog
 # Should-Stop:       $syslog
 # Default-Start:     2 3 4 5
-# Default-Stop:      S 0 1 6
+# Default-Stop:      0 1 6
 # Short-Description: network events dispatcher
 # Description:       This daemon automatically runs scripts when
 #                    NetworkManager changes the network state.

As the stop script do not seem to do anything except killing the
daemon, that task might be better left to the sendsigs script in
runlevel 0 and 6.  If this is indeed the case, I recommend removing 0
and 6 from the Default-Stop list.

Happy hacking,
--
Petter Reinholdtsen