[Pkg-utopia-maintainers] Bug#462012: Typo leads to missing s3_bios quirk for Lenovo X61, R61i

[Jim Paris]

Package: hal-info
Version: 20071212-2
Severity: normal
Tags: patch

Hi,

The file /usr/share/hal/fdi/information/10freedesktop/20-video-quirk-pm-lenovo.fdi
contains:
      <!-- X61* Tablet, R61i (7732) -->
      <match key="system.hardware.product" prefix_outof="7669;7764;7675,7732">
        <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
      </match>
The misplaced comma in prefix_outof means that neither 7675 nor 7732 is matched.
Attached is a patch to fix it.

For others hitting this problem, an easy fix is to create a file
/etc/hal/fdi/information/fix-quirk.fdi containing the correct entry:

<?xml version="1.0" encoding="ISO-8859-1"?> <!-- -*- SGML -*- --> 
<deviceinfo version="0.2">
  <device>
    <match key="system.hardware.vendor" string="LENOVO">
      <match key="system.hardware.product" prefix_outof="7669;7764;7675;7732">
        <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
      </match>
    </match>
  </device>
</deviceinfo>

-jim

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-rc8 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

-- no debconf information
-------------- next part --------------
diff -purN hal-info-orig/fdi/information/10freedesktop/20-video-quirk-pm-lenovo.fdi hal-info-20071212/fdi/information/10freedesktop/20-video-quirk-pm-lenovo.fdi
--- hal-info-orig/fdi/information/10freedesktop/20-video-quirk-pm-lenovo.fdi	2008-01-21 17:27:37.000000000 -0500
+++ hal-info-20071212/fdi/information/10freedesktop/20-video-quirk-pm-lenovo.fdi	2008-01-21 17:27:53.000000000 -0500
@@ -10,7 +10,7 @@
         <merge key="power_management.quirk.s3_mode" type="bool">true</merge>
       </match>
       <!-- X61* Tablet, R61i (7732) -->
-      <match key="system.hardware.product" prefix_outof="7669;7764;7675,7732">
+      <match key="system.hardware.product" prefix_outof="7669;7764;7675;7732">
         <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
       </match>
       <match key="system.hardware.product" prefix="63664DU">