[Pkg-utopia-maintainers] Bug#528383: hal: GNU/kFreeBSD support

[Michael Biebl]

Aurelien Jarno wrote:

> 
> You will find below a patch to make hal working on GNU/kFreeBSD, 
> including both changes to the packaging and upstream. It would be nice 
> if you can apply it for the upload of version 0.5.12. Thanks in 
> advance.


Hi Aurelien,

thanks for the patch, a few comments inline


> diff -u hal-0.5.12~git20090406.46dc48/debian/control hal-0.5.12~git20090406.46dc48/debian/control
> --- hal-0.5.12~git20090406.46dc48/debian/control
> +++ hal-0.5.12~git20090406.46dc48/debian/control
> @@ -32,7 +32,7 @@
>  
>  Package: hal
>  Architecture: any
> -Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, pciutils, usbutils, udev (>= 0.125), dbus (>= 0.61), lsb-base (>= 3.2-14), hal-info (>= 20070402), pm-utils, mount (>= 2.13), policykit (>= 0.7), consolekit (>= 0.3), acl
> +Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, pciutils, usbutils, udev (>= 0.125) [!kfreebsd-amd64 !kfreebsd-i386], dbus (>= 0.61), lsb-base (>= 3.2-14), hal-info (>= 20070402), pm-utils [!kfreebsd-amd64 !kfreebsd-i386], mount (>= 2.13) [!kfreebsd-amd64 !kfreebsd-i386], freebsd-utils [kfreebsd-amd64 kfreebsd-i386], policykit (>= 0.7), consolekit (>= 0.3), acl

Why has pm-utils be removed on kfreebsd?

>  Recommends: eject, libsmbios-bin [amd64 i386 lpia]
>  Suggests: gnome-device-manager
>  Description: Hardware Abstraction Layer
> @@ -125,0 +126,15 @@
> +Package: libhald-freebsd-probe0
> +Section: libs
> +Architecture: kfreebsd-i386 kfreebsd-amd64
> +Depends: ${shlibs:Depends}, ${misc:Depends}
> +Description: Hardware Abstraction Layer - shared library for device probing
> + HAL provides an abstract view on hardware.
> + .
> + This abstraction layer is simply an interface that makes it possible to
> + add support for new devices and new ways of connecting devices to the
> + computer, without modifying every application that uses the device.
> + It maintains a list of devices that currently exist, and can provide
> + information about those upon request.
> + .
> + This library provides device probing on FreeBSD.
> +

So this is library is more or less private to HAL. I'm wondering, if this lib
shouldn't rather be moved to /usr/lib/hal (and shipped as part of the hal
package) or libhald-freebsd-probe (in hald/freebsd/libprobe/Makefile.am) is made
a noinst ltlib. The latter would probably be my preference.

I'd really prefer if we don't need a separate binary package.


> --- hal-0.5.12~git20090406.46dc48.orig/debian/hal.install.kfreebsd-amd64
> +++ hal-0.5.12~git20090406.46dc48/debian/hal.install.kfreebsd-amd64
> @@ -0,0 +1,9 @@
> +debian/tmp/etc/
> +debian/tmp/usr/bin/
> +debian/tmp/usr/sbin/
> +debian/tmp/sbin/umount.hal usr/sbin
> +debian/tmp/usr/lib/hal/
> +debian/tmp/usr/share/hal/fdi/
> +debian/tmp/usr/share/PolicyKit/
> +debian/preferences.fdi  etc/hal/fdi/policy
> +debian/debian-storage-policy-ignore-fixed-crypto-drives.fdi usr/share/hal/fdi/policy/10osvendor
> only in patch2:
> unchanged:
> --- hal-0.5.12~git20090406.46dc48.orig/debian/hal.install.kfreebsd-i386
> +++ hal-0.5.12~git20090406.46dc48/debian/hal.install.kfreebsd-i386
> @@ -0,0 +1,9 @@
> +debian/tmp/etc/
> +debian/tmp/usr/bin/
> +debian/tmp/usr/sbin/
> +debian/tmp/sbin/umount.hal usr/sbin
> +debian/tmp/usr/lib/hal/
> +debian/tmp/usr/share/hal/fdi/
> +debian/tmp/usr/share/PolicyKit/
> +debian/preferences.fdi  etc/hal/fdi/policy
> +debian/debian-storage-policy-ignore-fixed-crypto-drives.fdi usr/share/hal/fdi/policy/10osvendor

This is because the udev rules files are not installed on freebsd, right? I'd
somehow prefer if we wouldn't have to maintain three separate files and keep
them in sync. Not sure if this easily doable though.

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20090514/455c093d/attachment.pgp>