[Pkg-utopia-maintainers] Bug#528383: hal: GNU/kFreeBSD support

[Aurelien Jarno]

On Thu, May 14, 2009 at 06:06:48PM +0200, Michael Biebl wrote:
> Aurelien Jarno wrote:
> 
> > 
> > You will find below a patch to make hal working on GNU/kFreeBSD, 
> > including both changes to the packaging and upstream. It would be nice 
> > if you can apply it for the upload of version 0.5.12. Thanks in 
> > advance.
> 
> 
> Hi Aurelien,
> 
> thanks for the patch, a few comments inline
> 
> 
> > diff -u hal-0.5.12~git20090406.46dc48/debian/control hal-0.5.12~git20090406.46dc48/debian/control
> > --- hal-0.5.12~git20090406.46dc48/debian/control
> > +++ hal-0.5.12~git20090406.46dc48/debian/control
> > @@ -32,7 +32,7 @@
> >  
> >  Package: hal
> >  Architecture: any
> > -Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, pciutils, usbutils, udev (>= 0.125), dbus (>= 0.61), lsb-base (>= 3.2-14), hal-info (>= 20070402), pm-utils, mount (>= 2.13), policykit (>= 0.7), consolekit (>= 0.3), acl
> > +Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, pciutils, usbutils, udev (>= 0.125) [!kfreebsd-amd64 !kfreebsd-i386], dbus (>= 0.61), lsb-base (>= 3.2-14), hal-info (>= 20070402), pm-utils [!kfreebsd-amd64 !kfreebsd-i386], mount (>= 2.13) [!kfreebsd-amd64 !kfreebsd-i386], freebsd-utils [kfreebsd-amd64 kfreebsd-i386], policykit (>= 0.7), consolekit (>= 0.3), acl
> 
> Why has pm-utils be removed on kfreebsd?

pm-utils is not installable on GNU/kFreeBSD as it is not installable
(depends on console-tools), and also this package looks very GNU/Linux
specific.

> >  Recommends: eject, libsmbios-bin [amd64 i386 lpia]
> >  Suggests: gnome-device-manager
> >  Description: Hardware Abstraction Layer
> > @@ -125,0 +126,15 @@
> > +Package: libhald-freebsd-probe0
> > +Section: libs
> > +Architecture: kfreebsd-i386 kfreebsd-amd64
> > +Depends: ${shlibs:Depends}, ${misc:Depends}
> > +Description: Hardware Abstraction Layer - shared library for device probing
> > + HAL provides an abstract view on hardware.
> > + .
> > + This abstraction layer is simply an interface that makes it possible to
> > + add support for new devices and new ways of connecting devices to the
> > + computer, without modifying every application that uses the device.
> > + It maintains a list of devices that currently exist, and can provide
> > + information about those upon request.
> > + .
> > + This library provides device probing on FreeBSD.
> > +
> 
> So this is library is more or less private to HAL. I'm wondering, if this lib
> shouldn't rather be moved to /usr/lib/hal (and shipped as part of the hal
> package) or libhald-freebsd-probe (in hald/freebsd/libprobe/Makefile.am) is made
> a noinst ltlib. The latter would probably be my preference.
> 
> I'd really prefer if we don't need a separate binary package.

Ok, I'll come back with another patch.

> > --- hal-0.5.12~git20090406.46dc48.orig/debian/hal.install.kfreebsd-amd64
> > +++ hal-0.5.12~git20090406.46dc48/debian/hal.install.kfreebsd-amd64
> > @@ -0,0 +1,9 @@
> > +debian/tmp/etc/
> > +debian/tmp/usr/bin/
> > +debian/tmp/usr/sbin/
> > +debian/tmp/sbin/umount.hal usr/sbin
> > +debian/tmp/usr/lib/hal/
> > +debian/tmp/usr/share/hal/fdi/
> > +debian/tmp/usr/share/PolicyKit/
> > +debian/preferences.fdi  etc/hal/fdi/policy
> > +debian/debian-storage-policy-ignore-fixed-crypto-drives.fdi usr/share/hal/fdi/policy/10osvendor
> > only in patch2:
> > unchanged:
> > --- hal-0.5.12~git20090406.46dc48.orig/debian/hal.install.kfreebsd-i386
> > +++ hal-0.5.12~git20090406.46dc48/debian/hal.install.kfreebsd-i386
> > @@ -0,0 +1,9 @@
> > +debian/tmp/etc/
> > +debian/tmp/usr/bin/
> > +debian/tmp/usr/sbin/
> > +debian/tmp/sbin/umount.hal usr/sbin
> > +debian/tmp/usr/lib/hal/
> > +debian/tmp/usr/share/hal/fdi/
> > +debian/tmp/usr/share/PolicyKit/
> > +debian/preferences.fdi  etc/hal/fdi/policy
> > +debian/debian-storage-policy-ignore-fixed-crypto-drives.fdi usr/share/hal/fdi/policy/10osvendor
> 
> This is because the udev rules files are not installed on freebsd, right? I'd
> somehow prefer if we wouldn't have to maintain three separate files and keep
> them in sync. Not sure if this easily doable though.
> 

Yes, they are udev rules, useless on GNU/kFreeBSD and not even installed
by 'make install'.

One solution is to not install those files from but conditionally from
debian/rules. I don't really like that, especially if the kfreebsd
version of the package also have specific files (the probe library).

As you noticed in your other mail, a better solution would be indeed to 
use a .kfreebsd file, but this feature was not existing when the bug
has been reported.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien at aurel32.net                 http://www.aurel32.net