[Pkg-utopia-maintainers] Bug#657108: FTBS: nm-glib-compat.h translate g_value_set/get_schar to g_value_set/get_char already defined

[Alban Browaeys]

Package: network-manager
Version: 0.9.2.0-2
Severity: normal

Dear Maintainer,

rebuilding the package locally leads to this failure:
# source='nm-vpn-plugin.c' object='libnm_glib_vpn_la-nm-vpn-plugin.lo' libtool=yes 
/bin/sh ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../libnm-util -I../marshallers  -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include   -pthread -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include   -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -c -o libnm_glib_vpn_la-nm-vpn-plugin.lo `test -f 'nm-vpn-plugin.c' || echo './'`nm-vpn-plugin.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../libnm-util -I../marshallers -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -pthread -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -c nm-vpn-plugin.c  -fPIC -DPIC -o .libs/libnm_glib_vpn_la-nm-vpn-plugin.o
In file included from /usr/include/glib-2.0/glib-object.h:38:0,
                 from nm-vpn-plugin.h:28,
                 from nm-vpn-plugin.c:26:
/usr/include/glib-2.0/gobject/gvaluetypes.h:185:13: error: conflicting types for 'g_value_set_char'
/usr/include/glib-2.0/gobject/gvaluetypes.h:181:13: note: previous declaration of 'g_value_set_char' was here
/usr/include/glib-2.0/gobject/gvaluetypes.h:187:14: error: conflicting types for 'g_value_get_char'
/usr/include/glib-2.0/gobject/gvaluetypes.h:183:14: note: previous declaration of 'g_value_get_char' was here

I traced it down to the package:
include/nm-glib-compat.h
#if !GLIB_CHECK_VERSION(2,31,0)
#define g_value_set_schar g_value_set_char
#define g_value_get_schar g_value_get_char
#endif

while /usr/include/glib-2.0/gobject/gvaluetypes.h has:
#ifndef G_DISABLE_DEPRECATED
void                  g_value_set_char          (GValue       *value,
                                                 gchar         v_char);
gchar                 g_value_get_char          (const GValue *value);
#endif
void                  g_value_set_schar         (GValue       *value,
                                                 gint8         v_char);
gint8                 g_value_get_schar         (const GValue *value);

in debian sid ie ibglib2.0-dev  2.30.2-5.
Locally I added around the type redefinition the same check as in gvaluetypes.h, ie the test for G_DISABLE_DEPRECATED:
#if !GLIB_CHECK_VERSION(2,31,0)
#ifdef G_DISABLE_DEPRECATED
#define g_value_set_schar g_value_set_char
#define g_value_get_schar g_value_get_char
#endif
#endif

Cheers
Alban


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages network-manager depends on:
ii  adduser                3.113
ii  dbus                   1.5.8-1
ii  isc-dhcp-client        4.2.2-2
ii  libc6                  2.13-24
ii  libdbus-1-3            1.5.8-1
ii  libdbus-glib-1-2       0.98-1
ii  libgcrypt11            1.5.0-3
ii  libglib2.0-0           2.30.2-5
ii  libgnutls26            2.12.16-1
ii  libgudev-1.0-0         175-3
ii  libnl-3-200            3.2.3-2
ii  libnl-route-3-200      3.2.3-2
ii  libnm-glib4            0.9.2.0-2
ii  libnm-util2            0.9.2.0-2
ii  libpolkit-gobject-1-0  0.104-1
ii  libuuid1               2.20.1-1.2
ii  lsb-base               3.2-28
ii  udev                   175-3
ii  wpasupplicant          0.7.3-6

Versions of packages network-manager recommends:
ii  crda          1.1.2-1
ii  dnsmasq-base  2.59-4
ii  iptables      1.4.12.2-1
ii  modemmanager  0.5-1
ii  policykit-1   0.104-1
ii  ppp           2.4.5-5

Versions of packages network-manager suggests:
pn  avahi-autoipd  <none>

-- Configuration Files:
/etc/NetworkManager/NetworkManager.conf changed [not included]

-- no debconf information