[Pkg-utopia-maintainers] Bug#712167: dbus: add upstart init support

[Simon McVittie]

On Thu, 13 Jun 2013 at 19:23:46 +0100, Dmitrijs Ledkovs wrote:
> please consider applying the following patch that adds upstart
> integration for the dbus package.

pkg-utopia are probably aware, but: dbus/testing has a CVE, so please don't
upload dbus/unstable until 1.6.12 has migrated.

> The upstart job attached will continue to honour existing
> settings for additional parameters from /etc/default/dbus, just like
> the current init.d script.

Do/should we support that file at all? I can't see anything in dbus-daemon
--help that you could put there without breaking system integration:

* --system, --fork: already there (or implied)

* --version, --introspect: don't actually run the daemon!

* --config-file=X, --session: avoid use of the right configuration file

* --print-address, --print-pid: irrelevant, we have no suitable fds to
  print these into

* --nofork, --nopidfile: I don't know whether the init script or Upstart
  job can survive these...

* --address: in practice moving the system dbus-daemon away from its
  well-known address is going to break the system

* --systemd-activation: er, not without systemd, which already uses it :-P

> Also conditional check whether dbus is
> running under upstart is added in the dbus.postinst for the upgrade
> notification.

This is an increasing amount of code to detect whether the dbus-daemon
is running, so that we know whether to prompt the user to reboot.

I think we should either use pgrep (false positive if a dbus-daemon or
similarly-named process is running, but it isn't the system bus), or
just assume the dbus-daemon *is* running. If dbus is installed, 99% of
the time the dbus-daemon will be running; and if it isn't, unnecessarily
suggesting a reboot doesn't seem particularly harmful. The sort of
people who would disable the dbus-daemon init script are quite
capable of ignoring a"please reboot" notification, if indeed they
ever see it.

    S