[Pkg-utopia-maintainers] Bug#790341: Bug#790341: network-manager: [regression] change in dnsmasq has broken connection sharing support

[Simon Kelley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

This is indeed a dnsmasq bug, introduced in 2.73. My fault, sorry.
Insufficient scrutiny of a "clean-up" patch. I just committed a fix to
the git repo.

Cheers,

Simon.


On 28/06/15 17:27, Michael Biebl wrote:
> Hi Paul,
> 
> thanks for your bug report.
> 
> Am 28.06.2015 um 10:23 schrieb Paul Wise:
>> Package: network-manager Version: 1.0.2-2 Severity: important 
>> Tags: patch
>> 
>> I sometimes share my WiFi connection to the Internet via
>> Ethernet. A recent upgrade of dnsmasq-base (I think 2.72-3.1+b1
>> to 2.73-1) on my system broke this as dnsmasq now tries to read
>> /etc/dnsmasq.conf when --conf-file is given without any argument,
>> with only dnsmasq-base, this file is not present. The fix is to
>> make it read /dev/null instead. I verified that that works by
>> diverting the dnsmasq binary and replacing the --conf-file
>> argument with a --conf-file=/dev/null argument.
>> 
>> src/dnsmasq-manager/nm-dnsmasq-manager.c:245 -
>> nm_cmd_line_add_string (cmd, "--conf-file"); +
>> nm_cmd_line_add_string (cmd, "--conf-file=/dev/null");
> 
> I can't find anything in dnsmasq's changelog for 2.73 in that
> regard. To me that looks like a regression in dnsmasq and should
> probably be fixed there.
> 
> I've CCed the dnsmasq maintainer, maybe he can comment on this.
> 
> If the current usage of --conf-file with an empty parameter was
> not officially supported and only working by accident, then this is
> indeed something which needs adjustments in NM, otherwise this bug
> report should be re-assigned to dnsmasq.
> 
> Regards, Michael
> 
> 
>> Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  Starting
>> dnsmasq... Jun 28 16:04:19 chianamo NetworkManager[844]: <info>
>> (eth0): device state change: ip-config -> ip-check (reason
>> 'none') [70 80 0] Jun 28 16:04:19 chianamo NetworkManager[844]:
>> <info>  (eth0): Activation: Stage 5 of 5 (IPv4 Commit) complete. 
>> Jun 28 16:04:19 chianamo NetworkManager[844]: dnsmasq --conf-file
>> --no-hosts --keep-in-foreground --bind-interfaces
>> --except-interface=lo --clear-on-reload --strict-order
>> --listen-address=10.42.0.1
>> --dhcp-range=10.42.0.10,10.42.0.254,60m
>> --dhcp-option=option:router,10.42.0.1 --dhcp-lease-max=50
>> --pid-file=/var/run/nm-dnsmasq-eth0.pid Jun 28 16:04:19 chianamo
>> NetworkManager[844]: <info>  (eth0): device state change:
>> ip-check -> secondaries (reason 'none') [80 90 0] Jun 28 16:04:19
>> chianamo NetworkManager[844]: <info>  (eth0): device state
>> change: secondaries -> activated (reason 'none') [90 100 0] Jun
>> 28 16:04:19 chianamo NetworkManager[844]: dnsmasq: cannot read
>> /etc/dnsmasq.conf: No such file or directory
> 
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVmZswAAoJEBXN2mrhkTWiGZUP+gNhjaPO0VHmNBlC+5JiB0fP
KHtlk21e60W22D6MDuii1R2PrJ3BFqkpvV3ysGG+W4Ida8FwvfztL5nLErUBrtdo
+JORheLuWiac2dc87AX0c/vf8auNtMZhoO+iblrTAh6FM3UbLcCUEB6mlWjwHazY
Y6l5brv5HMtY35JMFMoxSEwZhGVkG79lwB13fZmifLLvNDqAad5VE5xnG22uPjAw
+zjzAcBmZqPNfRtFSuBrI0lur5HgujEJa6zRGveONDBrlvI6VdB5PCRa/dWCVO+O
+2pxOOXIl4+5yBufmolkWj7BraUq0nU3MEGe9fIT671LOYW6ngpI83ICxJMyHeUf
QP4bhkV7DCcnKeiSADMtFxQKrMl0xbKyQCY7Ou4/us0BOkhffHpQGQKzcGmuFmwH
dCpuSTT4MzgkPJ7exwZ+uJTmZ+Skjm7/1F6KUsIz5QWzKhGjN1oYq/wUSFrQaIQD
FPh96kdNa7LRGn4egQDq5P+iQK1A5HJ20tlLAWnVjRQlDwlif4c4bA2RL9IVjafI
cmxuCgsk4c6J+4559LLGav97U2BqU5uSJ8VBd2IHOZMtUvxtC9wZ6VbJ7KexveXS
eL8WsW6RKDb0nTZiAJlTWvuwOzCSAClccHeExotTroOLCZ55xdwKqAKoAb0UOMPO
9qhlqNb7A4Yf8lqeDFtS
=2E+b
-----END PGP SIGNATURE-----