[Pkg-utopia-maintainers] Bug#811583: Bug#811583:

[Michael Biebl]

Hi Dave

Am 22.01.2016 um 17:40 schrieb David Malcolm:
> (I'm the upstream gcc author of -Wmisleading-indentation)
> 
> This issue has been fixed upstream in:
> http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=99ae6777893d0b149cbefac3f290c63c47e29f42
> 
> The code in question is here:
> https://sources.debian.net/src/modemmanager/1.4.12-1/libqcdm/tests/test-qcdm.c/#L46 https://sources.debian.net/src/modemmanager/1.4.12-1/libqcdm/tests/test-qcdm.c/#L52

There are more GCC 6 related build failures, even after fixing this one:


test-wmc.c: In function 'test_data_new':
test-wmc.c:45:2: error: statement is indented as if it were guarded
by... [-Werror=misleading-indentation]
  return d;
  ^~~~~~

test-wmc.c:42:5: note: ...this 'if' clause, but it is not
     if (port)
     ^~

test-wmc.c: In function 'test_data_free':
test-wmc.c:54:2: error: statement is indented as if it were guarded
by... [-Werror=misleading-indentation]
  g_free (d);
  ^~~~~~

test-wmc.c:51:5: note: ...this 'if' clause, but it is not
     if (d->com_data)
     ^~

cc1: all warnings being treated as errors
Makefile:554: recipe for target 'test_wmc-test-wmc.o' failed
make[3]: *** [test_wmc-test-wmc.o] Error 1
make[3]: Target 'all' not remade because of errors.
make[3]: Leaving directory '/tmp/modemmanager-1.4.12/libwmc/tests'


=> patch for that is attached. Dan, would be great if you can review and
apply.

==================================================================

cinterion/mm-broadband-modem-cinterion.c:86:30: error: 'bands_2g'
defined but not used [-Werror=unused-const-variable]
 static const CinterionBand2G bands_2g[] = {
                              ^~~~~~~~

cc1: all warnings being treated as errors
Makefile:2205: recipe for target
'cinterion/libmm_plugin_cinterion_la-mm-broadband-modem-cinterion.lo' failed
make[2]: ***
[cinterion/libmm_plugin_cinterion_la-mm-broadband-modem-cinterion.lo]
Error 1

==================================================================


novatel/mm-plugin-novatel.c:50:35: error: 'custom_at_probe' defined but
not used [-Werror=unused-const-variable]
 static const MMPortProbeAtCommand custom_at_probe[] = {
                                   ^~~~~~~~~~~~~~~

cc1: all warnings being treated as errors
Makefile:2478: recipe for target
'novatel/libmm_plugin_novatel_la-mm-plugin-novatel.lo' failed


==================================================================

test-wmc-utils.c:114:19: error: 'uml290_encap_outbuf' defined but not
used [-Werror=unused-const-variable]
static const char uml290_encap_outbuf[] = {
^~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors
Makefile:526: recipe for target 'test_wmc-test-wmc-utils.o' failed
make[4]: *** [test_wmc-test-wmc-utils.o] Error 1
make[4]: Leaving directory '/tmp/modemmanager-1.4.12/libwmc/tests'

Some of those might be real issues.
E.g. it's not clear to me, why the encapsulated uml290_encap_src is
compared against encap_outbuf and *not* uml290_encap_outbuf.

Dan, could you have a look?

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-white-space-indentation-fixes.patch
Type: text/x-patch
Size: 2020 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20160122/2d835cd6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20160122/2d835cd6/attachment.sig>