[Pkg-utopia-maintainers] Bug#815668: network-manager-gnome: I have the same assertion in 1.1.91-1 at line 1094

[Pawel Palucha]

Package: network-manager-gnome
Version: 1.1.91-1
Followup-For: Bug #815668

Dear Maintainer,

I have the same issues with nm-applet for few versions. In 1.1.91-1
the assertion is reported in line 1094:

nm-applet:ERROR:applet.c:1094:applet_get_first_active_vpn_connection:
assertion failed: (s_con)

I also sometimes use external scripts to setup VPN connection (mainly using
vpnc), so, looking also at the code, it is probably related.

The code causing assertion is:

s_con = nm_connection_get_setting_connection (connection);
assert(s_con);

However, in different part of the code null return from 
nm_connection_get_setting_connection does not cause assert. For example,
in applet_get_all_connections it just skips connection with null return 
value. I believe the same could be done in
applet_get_first_active_vpn_connection function. The code could be
modified as:

s_con = nm_connection_get_setting_connection (connection);
if (!s_con)
	continue;

Regards
Pawel

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pl_PL.utf8, LC_CTYPE=pl_PL.utf8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages network-manager-gnome depends on:
ii  dbus-x11                                     1.10.6-1
ii  dconf-gsettings-backend [gsettings-backend]  0.24.0-2
ii  gnome-icon-theme                             3.12.0-1
ii  libatk1.0-0                                  2.18.0-1
ii  libc6                                        2.21-9
ii  libcairo2                                    1.14.6-1
ii  libgdk-pixbuf2.0-0                           2.32.3-1.2
ii  libglib2.0-0                                 2.46.2-3
ii  libgtk-3-0                                   3.18.8-1
ii  libmm-glib0                                  1.4.12-1
ii  libnm0                                       1.1.91-1
ii  libnma0                                      1.1.91-1
ii  libnotify4                                   0.7.6-2
ii  libpango-1.0-0                               1.38.1-1
ii  libpangocairo-1.0-0                          1.38.1-1
ii  libsecret-1-0                                0.18.4-1
ii  network-manager                              1.1.91-1
ii  policykit-1-gnome                            0.105-2

Versions of packages network-manager-gnome recommends:
ii  gnome-keyring                        3.18.3-1
ii  iso-codes                            3.65-1
pn  mobile-broadband-provider-info       <none>
ii  notification-daemon                  3.18.2-1
ii  xfce4-notifyd [notification-daemon]  0.2.4-3+b1

Versions of packages network-manager-gnome suggests:
pn  network-manager-openconnect-gnome  <none>
ii  network-manager-openvpn-gnome      1.1.90-3
ii  network-manager-pptp-gnome         1.1.91-1
ii  network-manager-vpnc-gnome         1.1.91-1

-- no debconf information