[Pkg-utopia-maintainers] Bug#860045: Bug#860045: Bug#860045: Please don't use /var/run/$foo in network-manager anymore
Alf Gaida
agaida at siduction.org
Wed Apr 12 14:20:20 UTC 2017
> Please use the actual path, not some non-existing abbreviation.
will do so
> This is upgrade code from pre-jessie. This can be dropped.
i'm fine with - but we need some kind of daemon restart
> We should probably check for both paths here, for upgrade safety, i.e
> whether /etc/resolv.conf points to the old *or* new path.
ok, better safe than sorry.
>> diff --git a/debian/network-manager.preinst b/debian/network-manager.preinst
>> index 9fff61d..b4c8a05 100644
>> --- a/debian/network-manager.preinst
>> +++ b/debian/network-manager.preinst
>> @@ -45,6 +45,11 @@ case "$1" in
>> if dpkg --compare-versions "$2" lt "1.2.2-2"; then
>> deb-systemd-helper purge NetworkManager-wait-online.service
>> fi
>> +
>> + # Delete a symlink that points to /var/run
>> + if [ "$(readlink /etc/resolv.conf)" = /var/run/NetworkManager/resolv.conf ] ; then
>> + rm -f /etc/resolv.conf
>> + fi
> Why is that necessary? This appears to be a risky change with no clear
> explanation why it's needed.
>
in case the symlink points to the old location just remove the symlink -
an alternative would be the empty file - so NetworkManger can recreate
the link to the new location at the next start - there is no risk in
this. this is the same as in the other p-scripts - but you are right,
the intention should be documented
Will rework the patch
More information about the Pkg-utopia-maintainers
mailing list