[Pkg-utopia-maintainers] network-manager-l2tp package sponsorship [ITP]

[Douglas Kosovic]

Hi Michael,

Thanks for the suggestions and explanations, I've uploaded an updated revision of the package :
   https://mentors.debian.net/package/network-manager-l2tp


Cheers,
Doug

________________________________________
From: Michael Biebl <biebl at debian.org>
Sent: Thursday, 1 June 2017 3:02 AM
To: Douglas Kosovic; pkg-utopia-maintainers at lists.alioth.debian.org
Subject: Re: [Pkg-utopia-maintainers] network-manager-l2tp package sponsorship [ITP]

Hi Doug,

Am 21.05.2017 um 13:55 schrieb Douglas Kosovic:
> Hi,
>
> I'm the current upstream maintainer for NetworkManager-l2tp and I'm seeking a sponsor for the package. I'm also the Fedora and EPEL7 maintainer for the NetworkManager-l2tp RPM packages.
>
> NetworkManager-l2tp source code is based on NetworkManager-pptp and in turn, this network-manager-l2tp package request is based on the current Debian network-manager-pptp package.
>
> I hope this mailing list is the right place to seek sponsorship for the network-manager-l2tp package? According to the following page, they recommended contacting the appropriate packaging team first for sponsorship :
>    https://wiki.debian.org/Mentors/BTS
>

All in all, the packages looks quite ok.
A few notes:


a/ Build-Depends: libdbus-glib-1-dev
That doesn't seem necessary. The code doesn't use dbus-glib and
configure.ac doesn't check for it, so it seems safe to drop

b/ Build-Depends: dh-autoreconf, dh $@ --with autoreconf
With compat level 10, which you use, dh-autoreconf is enabled by default
and debhelper ensures it is installed.
So you can drop the Build-Depends and the autoreconf sequence in
debian/rules. See man debhelper → COMPATIBILITY LEVELS

c/ Breaks: network-manager-l2tp-gnome (<< 1.2.4)
   Replaces: network-manager-l2tp-gnome (<< 1.2.4)

This is unnecessary. Such a Breaks/Replaces is only necessary if you
move files from one package to another in a new version. Since this
package is new in the archive, this is obviously not needed.

d/ debian/copyright seems to be missing details about
./shared/nm-utils/ which seems to be mostly LGPL-2+ and
network-manager-l2tp.metainfo.xml.in says that the metadata files are
CC0-1.0

Regards,
Michael



--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?