[Pkg-utopia-maintainers] Bug#862803: Respect the DEB_BUILD_OPTIONS=nocheck option

Dan Nicholson dbn.lists at gmail.com
Wed May 17 11:07:55 UTC 2017


On Wed, 17 May 2017 12:15:36 +0200 Krzesimir Nowak <krzesimir at kinvolk.io
> wrote:
> 
> Attached patch should do the trick.

--- rules.old	2017-05-17 12:08:47.186950253 +0200
+++ rules	2017-05-17 12:10:35.833876166 +0200
@@ -27,7 +27,9 @@
 		$(NULL)
 
 override_dh_auto_test:
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
 	debian/test.sh
+endif
 
 override_dh_auto_install:
 	dh_auto_install

Actually, in the patch I think you want ifneq. This always trips me up,
but what happens is that $(filter will strip out everything except
nocheck from $(DEB_BUILD_OPTIONS). So, you want to test that the result
is _not_ empty. Or you could be explicit and check that the filtered
output matches nocheck.

https://www.gnu.org/software/make/manual/html_node/Text-Functions.html

It would be nice if make had a function for "is this word in a list",
but I don't think it does. The confusing ifeq + filter usage is about as
close as you can get.

--
Dan



More information about the Pkg-utopia-maintainers mailing list