[Pkg-utopia-maintainers] Bug#863560: network-manager-gnome: NetworkManager Applet does not hide unmanaged virtual interfaces

[Marcus Jodorf]

Package: network-manager-gnome
Version: 1.4.6-1
Severity: normal


Dear maintainer,

NetworkManager Applet shows useless entries of unmanaged interfaces.
In my case it is virtual interfaces from vmwware workstation.

# nmcli d
DEVICE    TYPE      STATE         CONNECTION  
wlp1s0    wifi      connected     mywifi 
cdc-wdm0  gsm       disconnected  --          
eth0      ethernet  unavailable   --          
vmnet1    ethernet  unmanaged     --          
vmnet8    ethernet  unmanaged     --          
lo        loopback  unmanaged     --          

Here vmnet1 and vmnet8 lead to completely useless entries greyed out in
the applets' menu like this
"Ethernet ()
 device not managed
 Ethernet ()
 device not managed"

Since these are always listed at the top of the menu taking up considerable
space this is simply annoying.

And this could be a usability problem when one has more such interfaces
and less screen estate.

Same problem with the 1.8.0-1 version from experimental.

Only way I found to get rid of these stupid entries was to change the
source:

--- network-manager-applet-1.4.6.orig/src/applet-device-ethernet.c
+++ network-manager-applet-1.4.6/src/applet-device-ethernet.c
@@ -73,6 +73,10 @@ ethernet_add_menu_item (NMDevice *device
        GtkWidget *item;
        gboolean carrier = TRUE;

+       if (nm_device_get_state (device)) {
+           return;
+       }
+
        if (multiple_devices) {
                const char *desc;

--- network-manager-applet-1.4.6.orig/src/applet.c
+++ network-manager-applet-1.4.6/src/applet.c
@@ -1319,11 +1319,6 @@ nma_menu_device_get_menu_item (NMDevice
                break;
        }
        
-       if (!managed) {
-               item = gtk_menu_item_new_with_label (_("device not managed"));
-               gtk_widget_set_sensitive (item, FALSE);
-       }
-
        return item;
 }


Best regards,

Marcus Jodorf



-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64
 (x86_64)

Kernel: Linux 4.11.0 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages network-manager-gnome depends on:
ii  dbus-user-session [default-dbus-session-bus]  1.10.18-1
ii  dbus-x11 [dbus-session-bus]                   1.10.18-1
ii  dconf-gsettings-backend [gsettings-backend]   0.26.0-2+b1
ii  libatk1.0-0                                   2.22.0-1
ii  libc6                                         2.24-10
ii  libcairo2                                     1.14.8-1
ii  libgdk-pixbuf2.0-0                            2.36.5-2
ii  libglib2.0-0                                  2.50.3-2
ii  libgtk-3-0                                    3.22.12-1
ii  libjansson4                                   2.9-1
ii  libmm-glib0                                   1.6.4-1
ii  libnm0                                        1.8.0-2
ii  libnma0                                       1.4.6-1
ii  libnotify4                                    0.7.7-2
ii  libpango-1.0-0                                1.40.5-1
ii  libpangocairo-1.0-0                           1.40.5-1
ii  libsecret-1-0                                 0.18.5-3.1
ii  network-manager                               1.6.2-3
ii  policykit-1-gnome [polkit-1-auth-agent]       0.105-6

Versions of packages network-manager-gnome recommends:
ii  gnome-keyring                        3.20.0-3
ii  iso-codes                            3.75-1
ii  mobile-broadband-provider-info       20161204-1
ii  notification-daemon                  3.20.0-1+b1
ii  xfce4-notifyd [notification-daemon]  0.3.6-1

Versions of packages network-manager-gnome suggests:
pn  network-manager-openconnect-gnome  <none>
pn  network-manager-openvpn-gnome      <none>
pn  network-manager-pptp-gnome         <none>
pn  network-manager-vpnc-gnome         <none>

-- no debconf information